From: Joe Perches <joe@perches.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
apw@canonical.com
Subject: Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to -mm tree
Date: Mon, 09 Jul 2012 16:21:07 -0700 [thread overview]
Message-ID: <1341876067.6118.67.camel@joe2Laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1207091553120.3552@chino.kir.corp.google.com>
On Mon, 2012-07-09 at 15:55 -0700, David Rientjes wrote:
> So, nack, don't start enforcing your own coding style and preferences in
> checkpatch.pl.
Not just my opinion.
https://lkml.org/lkml/2008/12/23/138
--------------------------------------------------------
Date: Tue, 23 Dec 2008 10:08:50 -0800 (PST)
From: Linus Torvalds <>
[]
Another example of this is "sizeof". The kernel universally (I hope) has
parenthesis around the sizeof argument, even though it's clearly not
required by the C language.
It's a coding standard.
--------------------------------------------------------
cheers, Joe
next prev parent reply other threads:[~2012-07-09 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120709215256.9A4F71E0043@wpzn4.hot.corp.google.com>
2012-07-09 22:23 ` + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to -mm tree David Rientjes
2012-07-09 22:36 ` Joe Perches
2012-07-09 22:55 ` David Rientjes
2012-07-09 23:21 ` Joe Perches [this message]
2012-07-09 23:47 ` David Rientjes
2012-07-10 0:55 ` Joe Perches
2012-07-10 1:50 ` David Rientjes
2012-07-10 2:03 ` Joe Perches
2012-07-10 2:21 ` David Rientjes
2012-07-10 5:12 ` Joe Perches
2012-07-10 2:28 ` Linus Torvalds
2012-07-10 2:49 ` David Rientjes
2012-07-12 5:23 ` [PATCH V2] checkpatch: Add check for use of sizeof without parenthesis Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341876067.6118.67.camel@joe2Laptop \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox