From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: mingo@kernel.org, hpa@zytor.com, eranian@google.com,
linux-kernel@vger.kernel.org, fweisbec@gmail.com,
akpm@linux-foundation.org, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org,
Robert Richter <robert.richter@amd.com>
Subject: Re: [tip:perf/core] perf/x86: Fix USER/KERNEL tagging of samples
Date: Tue, 10 Jul 2012 11:52:32 +0200 [thread overview]
Message-ID: <1341913952.3462.106.camel@twins> (raw)
In-Reply-To: <1341913846.3462.105.camel@twins>
On Tue, 2012-07-10 at 11:50 +0200, Peter Zijlstra wrote:
> + if (regs->cs != __USER32_CS && regs->cs != __USER_CS)
> + return 0;
> +
> + if (regs->ss != __USER32_DS && regs->ss != __USER_DS)
> + return 0;
Those should be return 1, they are a 32bit callchain, we just don't do
anything with it.
next prev parent reply other threads:[~2012-07-10 9:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 6:20 [tip:perf/core] perf/x86: Fix USER/KERNEL tagging of samples tip-bot for Peter Zijlstra
2012-07-06 16:29 ` Linus Torvalds
2012-07-06 18:12 ` Peter Zijlstra
2012-07-06 18:16 ` Linus Torvalds
2012-07-06 18:34 ` Linus Torvalds
2012-07-06 20:48 ` Peter Zijlstra
2012-07-06 20:59 ` Linus Torvalds
2012-07-09 11:23 ` Peter Zijlstra
2012-07-09 17:55 ` Linus Torvalds
2012-07-10 9:02 ` Peter Zijlstra
2012-07-10 9:48 ` Ingo Molnar
2012-07-10 9:50 ` Peter Zijlstra
2012-07-10 9:52 ` Peter Zijlstra [this message]
2012-07-10 9:55 ` Ingo Molnar
2012-07-31 17:57 ` [tip:perf/urgent] perf/x86: Fix USER/ KERNEL tagging of samples properly tip-bot for Peter Zijlstra
2012-07-09 18:41 ` [tip:perf/core] perf/x86: Fix USER/KERNEL tagging of samples Ingo Molnar
2012-07-10 7:54 ` Peter Zijlstra
2012-07-10 8:02 ` Ingo Molnar
2012-07-10 8:21 ` Ingo Molnar
2012-07-10 8:52 ` Peter Zijlstra
2012-07-10 9:48 ` Ingo Molnar
2012-07-31 18:11 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341913952.3462.106.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox