From: Joe Perches <joe@perches.com>
To: Toshiaki Yamane <yamanetoshi@gmail.com>
Cc: greg@kroah.com, willy@meta-x.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] panel: Use pr_err(...) rather than printk(KERN_ERR ...)
Date: Wed, 11 Jul 2012 08:13:23 -0700 [thread overview]
Message-ID: <1342019603.13724.65.camel@joe2Laptop> (raw)
In-Reply-To: <1341997147-25417-1-git-send-email-yamanetoshi@gmail.com>
On Wed, 2012-07-11 at 17:59 +0900, Toshiaki Yamane wrote:
> This change is inspired by checkpatch.
The changelog could be improved a bit. Maybe:
Added pr_fmt.
Removed unnecessary OOM messages.
Removed embedded message prefixes.
Added __func__ to all pr_err messages.
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
[]
> @@ -2110,10 +2110,8 @@ static void panel_attach(struct parport *port)
> return;
>
> if (pprt) {
> - printk(KERN_ERR
> - "panel_attach(): port->number=%d parport=%d, "
> - "already registered !\n",
> - port->number, parport);
> + pr_err("%s: port->number=%d parport=%d, already registerd !\n",
> + __func__, port->number, parport);
typo of registered
prev parent reply other threads:[~2012-07-11 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 8:59 [PATCH v2] panel: Use pr_err(...) rather than printk(KERN_ERR ...) Toshiaki Yamane
2012-07-11 15:13 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342019603.13724.65.camel@joe2Laptop \
--to=joe@perches.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@meta-x.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox