From: Li Zhong <zhong@linux.vnet.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
arjan@linux.intel.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Christian Kujau <lists@nerdbynature.de>,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH RESEND] Fix a dead loop in async_synchronize_full()
Date: Thu, 12 Jul 2012 17:56:28 +0800 [thread overview]
Message-ID: <1342086988.4091.44.camel@ThinkPad-T420> (raw)
In-Reply-To: <CABE8wwsqyo=BPCy4xy1PAVKFWe=GqYRdYowXkQ6UZoXdtEdCZA@mail.gmail.com>
On Wed, 2012-07-11 at 15:50 -0700, Dan Williams wrote:
> On Wed, Jul 11, 2012 at 3:42 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > The patch is fairly wordwrapped - please fix up your email client.
> >
> > More seriously, it does not apply to linux-next due to some fairly
> > significant changes which have been sitting in Dan's tree since May.
> > What's going on?
> >
>
> Those changes missed the 3.5 merge window, but now that they have
> Arjan's ack they should head upstream via James for 3.6. Right now
> they are on his pending [1] branch.
>
> As far as the comment:
>
> > It seems async_synchronize_full() wants to synchronize all entries in
> > all running lists(domains), so maybe we could just check the entry_count
> > to know whether all works are finished.
>
> ...at first glance this is what the new async patches achieve.
> async_synchronize_full should now sync work across all domains, but if
> you can reproduce this bug it would be nice to confirm that the
> pending changes fix it.
>
I have tested your pending patches, they fix the problem here.
But with ASYNC_DOMAIN_EXCLUSIVE added for the domains defined on the
stack, I think we lack a function that could wait for all the works in
all domains (however, maybe actually we don't need such an interface).
Also, I think it's not good to exclude them from
async_synchronize_full() just because they are defined on the stack.
> --
> Dan
>
> [1]: http://git.kernel.org/?p=linux/kernel/git/jejb/scsi.git;a=shortlog;h=refs/heads/pending
>
next prev parent reply other threads:[~2012-07-12 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 7:04 [PATCH RESEND] Fix a dead loop in async_synchronize_full() Li Zhong
2012-07-11 22:42 ` Andrew Morton
2012-07-11 22:50 ` Dan Williams
2012-07-12 9:56 ` Li Zhong [this message]
2012-07-12 16:41 ` Dan Williams
2012-07-16 18:32 ` Christian Kujau
2012-07-16 23:01 ` Dan Williams
2012-07-17 1:57 ` Paul E. McKenney
2012-07-17 2:42 ` Li Zhong
2012-07-12 2:49 ` Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342086988.4091.44.camel@ThinkPad-T420 \
--to=zhong@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox