Re: [PATCH 2/2] Made core dump functionality optional

Cong Wang
2012-07-03T04:55:55Z

On Tue, Jul 3, 2012 at 8:38 AM, Alex Kelly <alex.page.kelly@gmail.com> wrote:
> From: Alex <eshink@gmail.com>
>
> Adds an expert Kconfig option, CONFIG_COREDUMP, which allows disabling of core dump.
> This saves approximately 2.6k in the compiled kernel, and complements CONFIG_ELF_CORE,
> which now depends on it.
>
> CONFIG_COREDUMP also disables coredump-related sysctls, except for suid_dumpable and
> related functions, which are necessary for ptrace.
>
> Signed-off-by: Alex Kelly <alex.page.kelly@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Looks good, just one nitpick: would CONFIG_CORE_DUMP be better than
CONFIG_COREDUMP?

Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

Thanks.