* [PATCH 01/17] mfd: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 02/17] input/serio/hp_sdc.c: " Theodore Ts'o
` (15 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Samuel Ortiz
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
drivers/mfd/tps65010.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c
index 93d5fdf..da2691f 100644
--- a/drivers/mfd/tps65010.c
+++ b/drivers/mfd/tps65010.c
@@ -563,8 +563,7 @@ static int tps65010_probe(struct i2c_client *client,
*/
if (client->irq > 0) {
status = request_irq(client->irq, tps65010_irq,
- IRQF_SAMPLE_RANDOM | IRQF_TRIGGER_FALLING,
- DRIVER_NAME, tps);
+ IRQF_TRIGGER_FALLING, DRIVER_NAME, tps);
if (status < 0) {
dev_dbg(&client->dev, "can't get IRQ %d, err %d\n",
client->irq, status);
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 02/17] input/serio/hp_sdc.c: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
2012-07-17 21:32 ` [PATCH 01/17] mfd: remove IRQF_SAMPLE_RANDOM which is now a no-op Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-18 6:09 ` Dmitry Torokhov
2012-07-17 21:32 ` [PATCH 03/17] i2c-pmcmsp: " Theodore Ts'o
` (14 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Dmitry Torokhov
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/serio/hp_sdc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/hp_sdc.c b/drivers/input/serio/hp_sdc.c
index 09a0899..d7a7e54 100644
--- a/drivers/input/serio/hp_sdc.c
+++ b/drivers/input/serio/hp_sdc.c
@@ -878,7 +878,7 @@ static int __init hp_sdc_init(void)
#endif
errstr = "IRQ not available for";
- if (request_irq(hp_sdc.irq, &hp_sdc_isr, IRQF_SHARED|IRQF_SAMPLE_RANDOM,
+ if (request_irq(hp_sdc.irq, &hp_sdc_isr, IRQF_SHARED,
"HP SDC", &hp_sdc))
goto err1;
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 02/17] input/serio/hp_sdc.c: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 ` [PATCH 02/17] input/serio/hp_sdc.c: " Theodore Ts'o
@ 2012-07-18 6:09 ` Dmitry Torokhov
2012-07-18 17:05 ` Theodore Ts'o
0 siblings, 1 reply; 30+ messages in thread
From: Dmitry Torokhov @ 2012-07-18 6:09 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Linux Kernel Developers List
On Tue, Jul 17, 2012 at 05:32:21PM -0400, Theodore Ts'o wrote:
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
I assume you'll be merging it through random tree with the rest of the
patches?
> ---
> drivers/input/serio/hp_sdc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/hp_sdc.c b/drivers/input/serio/hp_sdc.c
> index 09a0899..d7a7e54 100644
> --- a/drivers/input/serio/hp_sdc.c
> +++ b/drivers/input/serio/hp_sdc.c
> @@ -878,7 +878,7 @@ static int __init hp_sdc_init(void)
> #endif
>
> errstr = "IRQ not available for";
> - if (request_irq(hp_sdc.irq, &hp_sdc_isr, IRQF_SHARED|IRQF_SAMPLE_RANDOM,
> + if (request_irq(hp_sdc.irq, &hp_sdc_isr, IRQF_SHARED,
> "HP SDC", &hp_sdc))
> goto err1;
>
> --
> 1.7.11.1.108.gb129051
>
--
Dmitry
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 02/17] input/serio/hp_sdc.c: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-18 6:09 ` Dmitry Torokhov
@ 2012-07-18 17:05 ` Theodore Ts'o
0 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-18 17:05 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Linux Kernel Developers List
On Tue, Jul 17, 2012 at 11:09:13PM -0700, Dmitry Torokhov wrote:
> On Tue, Jul 17, 2012 at 05:32:21PM -0400, Theodore Ts'o wrote:
> > With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> > no-op; interrupt randomness is now collected unconditionally in a very
> > low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> > flag was scheduled to be removed in 2009 on the
> > feature-removal-schedule, so this patch is preparation for the final
> > removal of this flag.
> >
> > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> I assume you'll be merging it through random tree with the rest of the
> patches?
Yes, correct.
Thanks!!
- Ted
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 03/17] i2c-pmcmsp: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
2012-07-17 21:32 ` [PATCH 01/17] mfd: remove IRQF_SAMPLE_RANDOM which is now a no-op Theodore Ts'o
2012-07-17 21:32 ` [PATCH 02/17] input/serio/hp_sdc.c: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 04/17] pda_power: " Theodore Ts'o
` (13 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Ben Dooks, Wolfram Sang
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: "Ben Dooks" <ben-linux@fluff.org>
Cc: "Wolfram Sang" <w.sang@pengutronix.de>
---
drivers/i2c/busses/i2c-pmcmsp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c
index 07b7447..3d71395 100644
--- a/drivers/i2c/busses/i2c-pmcmsp.c
+++ b/drivers/i2c/busses/i2c-pmcmsp.c
@@ -306,8 +306,7 @@ static int __devinit pmcmsptwi_probe(struct platform_device *pldev)
pmcmsptwi_data.irq = platform_get_irq(pldev, 0);
if (pmcmsptwi_data.irq) {
rc = request_irq(pmcmsptwi_data.irq, &pmcmsptwi_interrupt,
- IRQF_SHARED | IRQF_SAMPLE_RANDOM,
- pldev->name, &pmcmsptwi_data);
+ IRQF_SHARED, pldev->name, &pmcmsptwi_data);
if (rc == 0) {
/*
* Enable 'DONE' interrupt only.
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 04/17] pda_power: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (2 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 03/17] i2c-pmcmsp: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-18 4:00 ` Anton Vorontsov
2012-07-17 21:32 ` [PATCH 05/17] n2_crypto: " Theodore Ts'o
` (12 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List
Cc: Theodore Ts'o, Anton Vorontsov, David Woodhouse
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Anton Vorontsov <cbou@mail.ru>
Cc: David Woodhouse <dwmw2@infradead.org>
---
drivers/power/pda_power.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
index 214468f..db5c526 100644
--- a/drivers/power/pda_power.c
+++ b/drivers/power/pda_power.c
@@ -24,11 +24,7 @@
static inline unsigned int get_irq_flags(struct resource *res)
{
- unsigned int flags = IRQF_SAMPLE_RANDOM | IRQF_SHARED;
-
- flags |= res->flags & IRQF_TRIGGER_MASK;
-
- return flags;
+ return IRQF_SHARED | (res->flags & IRQF_TRIGGER_MASK);
}
static struct device *dev;
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 04/17] pda_power: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 ` [PATCH 04/17] pda_power: " Theodore Ts'o
@ 2012-07-18 4:00 ` Anton Vorontsov
2012-07-18 4:18 ` Theodore Ts'o
0 siblings, 1 reply; 30+ messages in thread
From: Anton Vorontsov @ 2012-07-18 4:00 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Linux Kernel Developers List, David Woodhouse
On Tue, Jul 17, 2012 at 05:32:23PM -0400, Theodore Ts'o wrote:
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Anton Vorontsov <cbou@mail.ru>
> Cc: David Woodhouse <dwmw2@infradead.org>
> ---
Applied, thanks!
> drivers/power/pda_power.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
> index 214468f..db5c526 100644
> --- a/drivers/power/pda_power.c
> +++ b/drivers/power/pda_power.c
> @@ -24,11 +24,7 @@
>
> static inline unsigned int get_irq_flags(struct resource *res)
> {
> - unsigned int flags = IRQF_SAMPLE_RANDOM | IRQF_SHARED;
> -
> - flags |= res->flags & IRQF_TRIGGER_MASK;
> -
> - return flags;
> + return IRQF_SHARED | (res->flags & IRQF_TRIGGER_MASK);
> }
>
> static struct device *dev;
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH 04/17] pda_power: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-18 4:00 ` Anton Vorontsov
@ 2012-07-18 4:18 ` Theodore Ts'o
2012-07-18 4:56 ` Anton Vorontsov
0 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-18 4:18 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Linux Kernel Developers List, David Woodhouse
On Tue, Jul 17, 2012 at 09:00:09PM -0700, Anton Vorontsov wrote:
> On Tue, Jul 17, 2012 at 05:32:23PM -0400, Theodore Ts'o wrote:
> > With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> > no-op; interrupt randomness is now collected unconditionally in a very
> > low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> > flag was scheduled to be removed in 2009 on the
> > feature-removal-schedule, so this patch is preparation for the final
> > removal of this flag.
> >
> > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> > Cc: Anton Vorontsov <cbou@mail.ru>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > ---
>
> Applied, thanks!
My original plan was to carry the patch in the random.git tree, so
that it only gets applied after the new random interrupt sampling
commit has gone in. If you carry it in your tree, then the
/dev/random seeding for your platform will be worse until the
random.git tree is merged in.....
- Ted
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 04/17] pda_power: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-18 4:18 ` Theodore Ts'o
@ 2012-07-18 4:56 ` Anton Vorontsov
0 siblings, 0 replies; 30+ messages in thread
From: Anton Vorontsov @ 2012-07-18 4:56 UTC (permalink / raw)
To: Theodore Ts'o, Linux Kernel Developers List, David Woodhouse
On Wed, Jul 18, 2012 at 12:18:20AM -0400, Theodore Ts'o wrote:
> On Tue, Jul 17, 2012 at 09:00:09PM -0700, Anton Vorontsov wrote:
> > On Tue, Jul 17, 2012 at 05:32:23PM -0400, Theodore Ts'o wrote:
> > > With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> > > no-op; interrupt randomness is now collected unconditionally in a very
> > > low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> > > flag was scheduled to be removed in 2009 on the
> > > feature-removal-schedule, so this patch is preparation for the final
> > > removal of this flag.
> > >
> > > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> > > Cc: Anton Vorontsov <cbou@mail.ru>
> > > Cc: David Woodhouse <dwmw2@infradead.org>
> > > ---
> >
> > Applied, thanks!
>
> My original plan was to carry the patch in the random.git tree, so
> that it only gets applied after the new random interrupt sampling
> commit has gone in. If you carry it in your tree, then the
> /dev/random seeding for your platform will be worse until the
> random.git tree is merged in.....
Oh, I see. OK, dropped.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 05/17] n2_crypto: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (3 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 04/17] pda_power: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-18 0:48 ` Herbert Xu
2012-07-17 21:32 ` [PATCH 06/17] xen-blkfront: " Theodore Ts'o
` (11 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Herbert Xu
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
---
drivers/crypto/n2_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index 67b97c5..a8bd031 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -1610,8 +1610,7 @@ static int spu_map_ino(struct platform_device *dev, struct spu_mdesc_info *ip,
sprintf(p->irq_name, "%s-%d", irq_name, index);
- return request_irq(p->irq, handler, IRQF_SAMPLE_RANDOM,
- p->irq_name, p);
+ return request_irq(p->irq, handler, 0, p->irq_name, p);
}
static struct kmem_cache *queue_cache[2];
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 06/17] xen-blkfront: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (4 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 05/17] n2_crypto: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-19 19:44 ` Konrad Rzeszutek Wilk
2012-07-17 21:32 ` [PATCH 07/17] drivers: hv: " Theodore Ts'o
` (10 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List
Cc: Theodore Ts'o, Konrad Rzeszutek Wilk, Jeremy Fitzhardinge
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
---
drivers/block/xen-blkfront.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 60eed4b..8f7a071 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -854,9 +854,8 @@ static int setup_blkring(struct xenbus_device *dev,
if (err)
goto fail;
- err = bind_evtchn_to_irqhandler(info->evtchn,
- blkif_interrupt,
- IRQF_SAMPLE_RANDOM, "blkif", info);
+ err = bind_evtchn_to_irqhandler(info->evtchn, blkif_interrupt, 0,
+ "blkif", info);
if (err <= 0) {
xenbus_dev_fatal(dev, err,
"bind_evtchn_to_irqhandler failed");
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 06/17] xen-blkfront: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 ` [PATCH 06/17] xen-blkfront: " Theodore Ts'o
@ 2012-07-19 19:44 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 30+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-07-19 19:44 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Linux Kernel Developers List, Jeremy Fitzhardinge
On Tue, Jul 17, 2012 at 05:32:25PM -0400, Theodore Ts'o wrote:
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Jeremy Fitzhardinge <jeremy@goop.org>
> ---
> drivers/block/xen-blkfront.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 60eed4b..8f7a071 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -854,9 +854,8 @@ static int setup_blkring(struct xenbus_device *dev,
> if (err)
> goto fail;
>
> - err = bind_evtchn_to_irqhandler(info->evtchn,
> - blkif_interrupt,
> - IRQF_SAMPLE_RANDOM, "blkif", info);
> + err = bind_evtchn_to_irqhandler(info->evtchn, blkif_interrupt, 0,
> + "blkif", info);
> if (err <= 0) {
> xenbus_dev_fatal(dev, err,
> "bind_evtchn_to_irqhandler failed");
> --
> 1.7.11.1.108.gb129051
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 07/17] drivers: hv: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (5 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 06/17] xen-blkfront: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-18 13:14 ` KY Srinivasan
2012-07-17 21:32 ` [PATCH 08/17] uartlite: " Theodore Ts'o
` (9 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List
Cc: Theodore Ts'o, K. Y. Srinivasan, Haiyang Zhang
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/hv/vmbus_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index a220e57..4748086 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -545,8 +545,7 @@ static int vmbus_bus_init(int irq)
if (ret)
goto err_cleanup;
- ret = request_irq(irq, vmbus_isr, IRQF_SAMPLE_RANDOM,
- driver_name, hv_acpi_dev);
+ ret = request_irq(irq, vmbus_isr, 0, driver_name, hv_acpi_dev);
if (ret != 0) {
pr_err("Unable to request IRQ %d\n",
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* RE: [PATCH 07/17] drivers: hv: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 ` [PATCH 07/17] drivers: hv: " Theodore Ts'o
@ 2012-07-18 13:14 ` KY Srinivasan
0 siblings, 0 replies; 30+ messages in thread
From: KY Srinivasan @ 2012-07-18 13:14 UTC (permalink / raw)
To: Theodore Ts'o, Linux Kernel Developers List; +Cc: Haiyang Zhang
> -----Original Message-----
> From: Theodore Ts'o [mailto:tytso@mit.edu]
> Sent: Tuesday, July 17, 2012 5:32 PM
> To: Linux Kernel Developers List
> Cc: Theodore Ts'o; KY Srinivasan; Haiyang Zhang
> Subject: [PATCH 07/17] drivers: hv: remove IRQF_SAMPLE_RANDOM which is
> now a no-op
>
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
Acked-by: "K. Y. Srinivasan" <kys@microsoft.com>
Regards,
K. Y
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 08/17] uartlite: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (6 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 07/17] drivers: hv: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-18 4:41 ` Peter Korsgaard
2012-07-17 21:32 ` [PATCH 09/17] goku_udc: remove IRQF_SAMPLE_RANDOM which was commented out Theodore Ts'o
` (8 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Peter Korsgaard
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Peter Korsgaard <jacmet@sunsite.dk>
---
drivers/tty/serial/uartlite.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
index 6cd4143..6579ffd 100644
--- a/drivers/tty/serial/uartlite.c
+++ b/drivers/tty/serial/uartlite.c
@@ -216,8 +216,7 @@ static int ulite_startup(struct uart_port *port)
{
int ret;
- ret = request_irq(port->irq, ulite_isr,
- IRQF_SHARED | IRQF_SAMPLE_RANDOM, "uartlite", port);
+ ret = request_irq(port->irq, ulite_isr, IRQF_SHARED, "uartlite", port);
if (ret)
return ret;
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 08/17] uartlite: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 ` [PATCH 08/17] uartlite: " Theodore Ts'o
@ 2012-07-18 4:41 ` Peter Korsgaard
0 siblings, 0 replies; 30+ messages in thread
From: Peter Korsgaard @ 2012-07-18 4:41 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Linux Kernel Developers List
>>>>> "Theodore" == Theodore Ts'o <tytso@mit.edu> writes:
Theodore> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
Theodore> no-op; interrupt randomness is now collected unconditionally in a very
Theodore> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
Theodore> flag was scheduled to be removed in 2009 on the
Theodore> feature-removal-schedule, so this patch is preparation for the final
Theodore> removal of this flag.
Theodore> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore> Cc: Peter Korsgaard <jacmet@sunsite.dk>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 09/17] goku_udc: remove IRQF_SAMPLE_RANDOM which was commented out
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (7 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 08/17] uartlite: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 10/17] omap_udc: remove IRQF_SAMPLE_RANDOM which is now a no-op Theodore Ts'o
` (7 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Felipe Balbi
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule.
The flag was only commented-out in the driver, but we should just
remove it altogether.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Felipe Balbi <balbi@ti.com>
---
drivers/usb/gadget/goku_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c
index 3d28fb9..9fd7886 100644
--- a/drivers/usb/gadget/goku_udc.c
+++ b/drivers/usb/gadget/goku_udc.c
@@ -1836,7 +1836,7 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id)
/* init to known state, then setup irqs */
udc_reset(dev);
udc_reinit (dev);
- if (request_irq(pdev->irq, goku_irq, IRQF_SHARED/*|IRQF_SAMPLE_RANDOM*/,
+ if (request_irq(pdev->irq, goku_irq, IRQF_SHARED,
driver_name, dev) != 0) {
DBG(dev, "request interrupt %d failed\n", pdev->irq);
retval = -EBUSY;
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 10/17] omap_udc: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (8 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 09/17] goku_udc: remove IRQF_SAMPLE_RANDOM which was commented out Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 11/17] pxa25x_udc: " Theodore Ts'o
` (6 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Felipe Balbi
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Felipe Balbi <balbi@ti.com>
---
drivers/usb/gadget/omap_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index a460e8c..2980100 100644
--- a/drivers/usb/gadget/omap_udc.c
+++ b/drivers/usb/gadget/omap_udc.c
@@ -2944,7 +2944,7 @@ known:
/* USB general purpose IRQ: ep0, state changes, dma, etc */
status = request_irq(pdev->resource[1].start, omap_udc_irq,
- IRQF_SAMPLE_RANDOM, driver_name, udc);
+ 0, driver_name, udc);
if (status != 0) {
ERR("can't get irq %d, err %d\n",
(int) pdev->resource[1].start, status);
@@ -2953,7 +2953,7 @@ known:
/* USB "non-iso" IRQ (PIO for all but ep0) */
status = request_irq(pdev->resource[2].start, omap_udc_pio_irq,
- IRQF_SAMPLE_RANDOM, "omap_udc pio", udc);
+ 0, "omap_udc pio", udc);
if (status != 0) {
ERR("can't get irq %d, err %d\n",
(int) pdev->resource[2].start, status);
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 11/17] pxa25x_udc: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (9 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 10/17] omap_udc: remove IRQF_SAMPLE_RANDOM which is now a no-op Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-19 3:07 ` Haojian Zhuang
2012-07-17 21:32 ` [PATCH 12/17] isp1301_omap: " Theodore Ts'o
` (5 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List
Cc: Theodore Ts'o, Eric Miao, Russell King, Haojian Zhuang
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
---
drivers/usb/gadget/pxa25x_udc.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c
index f7ff9e8..c319814 100644
--- a/drivers/usb/gadget/pxa25x_udc.c
+++ b/drivers/usb/gadget/pxa25x_udc.c
@@ -2200,19 +2200,15 @@ static int __init pxa25x_udc_probe(struct platform_device *pdev)
#ifdef CONFIG_ARCH_LUBBOCK
if (machine_is_lubbock()) {
- retval = request_irq(LUBBOCK_USB_DISC_IRQ,
- lubbock_vbus_irq,
- IRQF_SAMPLE_RANDOM,
- driver_name, dev);
+ retval = request_irq(LUBBOCK_USB_DISC_IRQ, lubbock_vbus_irq,
+ 0, driver_name, dev);
if (retval != 0) {
pr_err("%s: can't get irq %i, err %d\n",
driver_name, LUBBOCK_USB_DISC_IRQ, retval);
goto err_irq_lub;
}
- retval = request_irq(LUBBOCK_USB_IRQ,
- lubbock_vbus_irq,
- IRQF_SAMPLE_RANDOM,
- driver_name, dev);
+ retval = request_irq(LUBBOCK_USB_IRQ, lubbock_vbus_irq,
+ 0, driver_name, dev);
if (retval != 0) {
pr_err("%s: can't get irq %i, err %d\n",
driver_name, LUBBOCK_USB_IRQ, retval);
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 11/17] pxa25x_udc: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 ` [PATCH 11/17] pxa25x_udc: " Theodore Ts'o
@ 2012-07-19 3:07 ` Haojian Zhuang
0 siblings, 0 replies; 30+ messages in thread
From: Haojian Zhuang @ 2012-07-19 3:07 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Linux Kernel Developers List, Eric Miao, Russell King
On Wed, Jul 18, 2012 at 5:32 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> ---
> drivers/usb/gadget/pxa25x_udc.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 12/17] isp1301_omap: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (10 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 11/17] pxa25x_udc: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 13/17] board-palmz71: " Theodore Ts'o
` (4 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Felipe Balbi
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Felipe Balbi <balbi@ti.com>
---
drivers/usb/otg/isp1301_omap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/otg/isp1301_omap.c b/drivers/usb/otg/isp1301_omap.c
index 70cf5d7..512397a 100644
--- a/drivers/usb/otg/isp1301_omap.c
+++ b/drivers/usb/otg/isp1301_omap.c
@@ -1575,7 +1575,6 @@ isp1301_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
isp->irq_type = IRQF_TRIGGER_FALLING;
}
- isp->irq_type |= IRQF_SAMPLE_RANDOM;
status = request_irq(i2c->irq, isp1301_irq,
isp->irq_type, DRIVER_NAME, isp);
if (status < 0) {
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 13/17] board-palmz71: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (11 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 12/17] isp1301_omap: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 14/17] [ARM] pxa: " Theodore Ts'o
` (3 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, Tony Lindgren
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap1/board-palmz71.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap1/board-palmz71.c b/arch/arm/mach-omap1/board-palmz71.c
index 3c71c6b..efcd365 100644
--- a/arch/arm/mach-omap1/board-palmz71.c
+++ b/arch/arm/mach-omap1/board-palmz71.c
@@ -288,8 +288,7 @@ palmz71_gpio_setup(int early)
}
gpio_direction_input(PALMZ71_USBDETECT_GPIO);
if (request_irq(gpio_to_irq(PALMZ71_USBDETECT_GPIO),
- palmz71_powercable, IRQF_SAMPLE_RANDOM,
- "palmz71-cable", NULL))
+ palmz71_powercable, 0, "palmz71-cable", NULL))
printk(KERN_ERR
"IRQ request for power cable failed!\n");
palmz71_powercable(gpio_to_irq(PALMZ71_USBDETECT_GPIO), NULL);
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 14/17] [ARM] pxa: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (12 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 13/17] board-palmz71: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-19 3:08 ` Haojian Zhuang
2012-07-17 21:32 ` [PATCH 15/17] sparc/ldc: " Theodore Ts'o
` (2 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List
Cc: Theodore Ts'o, Eric Miao, Russell King, Haojian Zhuang
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
---
arch/arm/mach-pxa/lubbock.c | 2 +-
arch/arm/mach-pxa/magician.c | 5 ++---
arch/arm/mach-pxa/trizeps4.c | 4 ++--
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-pxa/lubbock.c b/arch/arm/mach-pxa/lubbock.c
index 6bb3f47..0ca0db7 100644
--- a/arch/arm/mach-pxa/lubbock.c
+++ b/arch/arm/mach-pxa/lubbock.c
@@ -456,7 +456,7 @@ static int lubbock_mci_init(struct device *dev,
init_timer(&mmc_timer);
mmc_timer.data = (unsigned long) data;
return request_irq(LUBBOCK_SD_IRQ, lubbock_detect_int,
- IRQF_SAMPLE_RANDOM, "lubbock-sd-detect", data);
+ 0, "lubbock-sd-detect", data);
}
static int lubbock_mci_get_ro(struct device *dev)
diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach-pxa/magician.c
index 2db697c..39561dc 100644
--- a/arch/arm/mach-pxa/magician.c
+++ b/arch/arm/mach-pxa/magician.c
@@ -633,9 +633,8 @@ static struct platform_device bq24022 = {
static int magician_mci_init(struct device *dev,
irq_handler_t detect_irq, void *data)
{
- return request_irq(IRQ_MAGICIAN_SD, detect_irq,
- IRQF_DISABLED | IRQF_SAMPLE_RANDOM,
- "mmc card detect", data);
+ return request_irq(IRQ_MAGICIAN_SD, detect_irq, IRQF_DISABLED,
+ "mmc card detect", data);
}
static void magician_mci_exit(struct device *dev, void *data)
diff --git a/arch/arm/mach-pxa/trizeps4.c b/arch/arm/mach-pxa/trizeps4.c
index 2b6ac00..166dd32 100644
--- a/arch/arm/mach-pxa/trizeps4.c
+++ b/arch/arm/mach-pxa/trizeps4.c
@@ -332,8 +332,8 @@ static int trizeps4_mci_init(struct device *dev, irq_handler_t mci_detect_int,
int err;
err = request_irq(TRIZEPS4_MMC_IRQ, mci_detect_int,
- IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_SAMPLE_RANDOM,
- "MMC card detect", data);
+ IRQF_DISABLED | IRQF_TRIGGER_RISING,
+ "MMC card detect", data);
if (err) {
printk(KERN_ERR "trizeps4_mci_init: MMC/SD: can't request"
"MMC card detect IRQ\n");
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 14/17] [ARM] pxa: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 ` [PATCH 14/17] [ARM] pxa: " Theodore Ts'o
@ 2012-07-19 3:08 ` Haojian Zhuang
0 siblings, 0 replies; 30+ messages in thread
From: Haojian Zhuang @ 2012-07-19 3:08 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Linux Kernel Developers List, Eric Miao, Russell King
On Wed, Jul 18, 2012 at 5:32 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> ---
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 15/17] sparc/ldc: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (13 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 14/17] [ARM] pxa: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-17 22:06 ` David Miller
2012-07-17 21:32 ` [PATCH 16/17] um: " Theodore Ts'o
2012-07-17 21:32 ` [PATCH 17/17] random: final removal of IRQF_SAMPLE_RANDOM Theodore Ts'o
16 siblings, 1 reply; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o, David S. Miller
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: "David S. Miller" <davem@davemloft.net>
---
arch/sparc/kernel/ldc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/sparc/kernel/ldc.c b/arch/sparc/kernel/ldc.c
index 435e406..81d92fc 100644
--- a/arch/sparc/kernel/ldc.c
+++ b/arch/sparc/kernel/ldc.c
@@ -1250,14 +1250,12 @@ int ldc_bind(struct ldc_channel *lp, const char *name)
snprintf(lp->rx_irq_name, LDC_IRQ_NAME_MAX, "%s RX", name);
snprintf(lp->tx_irq_name, LDC_IRQ_NAME_MAX, "%s TX", name);
- err = request_irq(lp->cfg.rx_irq, ldc_rx,
- IRQF_SAMPLE_RANDOM | IRQF_DISABLED,
+ err = request_irq(lp->cfg.rx_irq, ldc_rx, IRQF_DISABLED,
lp->rx_irq_name, lp);
if (err)
return err;
- err = request_irq(lp->cfg.tx_irq, ldc_tx,
- IRQF_SAMPLE_RANDOM | IRQF_DISABLED,
+ err = request_irq(lp->cfg.tx_irq, ldc_tx, IRQF_DISABLED,
lp->tx_irq_name, lp);
if (err) {
free_irq(lp->cfg.rx_irq, lp);
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 15/17] sparc/ldc: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 ` [PATCH 15/17] sparc/ldc: " Theodore Ts'o
@ 2012-07-17 22:06 ` David Miller
0 siblings, 0 replies; 30+ messages in thread
From: David Miller @ 2012-07-17 22:06 UTC (permalink / raw)
To: tytso; +Cc: linux-kernel
From: Theodore Ts'o <tytso@mit.edu>
Date: Tue, 17 Jul 2012 17:32:34 -0400
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 16/17] um: remove IRQF_SAMPLE_RANDOM which is now a no-op
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (14 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 15/17] sparc/ldc: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 17/17] random: final removal of IRQF_SAMPLE_RANDOM Theodore Ts'o
16 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List
Cc: Theodore Ts'o, Jeff Dike, Richard Weinberger
With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
no-op; interrupt randomness is now collected unconditionally in a very
low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
flag was scheduled to be removed in 2009 on the
feature-removal-schedule, so this patch is preparation for the final
removal of this flag.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
---
arch/um/drivers/line.c | 13 ++++++-------
arch/um/drivers/mconsole_kern.c | 3 +--
arch/um/drivers/port_kern.c | 6 ++----
arch/um/drivers/random.c | 3 +--
arch/um/drivers/xterm_kern.c | 3 +--
arch/um/kernel/sigio.c | 3 +--
6 files changed, 12 insertions(+), 19 deletions(-)
diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
index acfd0e0..ac9d25c 100644
--- a/arch/um/drivers/line.c
+++ b/arch/um/drivers/line.c
@@ -362,18 +362,18 @@ static irqreturn_t line_write_interrupt(int irq, void *data)
int line_setup_irq(int fd, int input, int output, struct line *line, void *data)
{
const struct line_driver *driver = line->driver;
- int err = 0, flags = IRQF_SHARED | IRQF_SAMPLE_RANDOM;
+ int err = 0;
if (input)
err = um_request_irq(driver->read_irq, fd, IRQ_READ,
- line_interrupt, flags,
- driver->read_irq_name, data);
+ line_interrupt, IRQF_SHARED,
+ driver->read_irq_name, data);
if (err)
return err;
if (output)
err = um_request_irq(driver->write_irq, fd, IRQ_WRITE,
- line_write_interrupt, flags,
- driver->write_irq_name, data);
+ line_write_interrupt, IRQF_SHARED,
+ driver->write_irq_name, data);
return err;
}
@@ -779,8 +779,7 @@ void register_winch_irq(int fd, int tty_fd, int pid, struct tty_struct *tty,
.stack = stack });
if (um_request_irq(WINCH_IRQ, fd, IRQ_READ, winch_interrupt,
- IRQF_SHARED | IRQF_SAMPLE_RANDOM,
- "winch", winch) < 0) {
+ IRQF_SHARED, "winch", winch) < 0) {
printk(KERN_ERR "register_winch_irq - failed to register "
"IRQ\n");
goto out_free;
diff --git a/arch/um/drivers/mconsole_kern.c b/arch/um/drivers/mconsole_kern.c
index 88e466b..e1c5197 100644
--- a/arch/um/drivers/mconsole_kern.c
+++ b/arch/um/drivers/mconsole_kern.c
@@ -775,8 +775,7 @@ static int __init mconsole_init(void)
register_reboot_notifier(&reboot_notifier);
err = um_request_irq(MCONSOLE_IRQ, sock, IRQ_READ, mconsole_interrupt,
- IRQF_SHARED | IRQF_SAMPLE_RANDOM,
- "mconsole", (void *)sock);
+ IRQF_SHARED, "mconsole", (void *)sock);
if (err) {
printk(KERN_ERR "Failed to get IRQ for management console\n");
goto out;
diff --git a/arch/um/drivers/port_kern.c b/arch/um/drivers/port_kern.c
index 11866ff..1d83d50 100644
--- a/arch/um/drivers/port_kern.c
+++ b/arch/um/drivers/port_kern.c
@@ -100,8 +100,7 @@ static int port_accept(struct port_list *port)
.port = port });
if (um_request_irq(TELNETD_IRQ, socket[0], IRQ_READ, pipe_interrupt,
- IRQF_SHARED | IRQF_SAMPLE_RANDOM,
- "telnetd", conn)) {
+ IRQF_SHARED, "telnetd", conn)) {
printk(KERN_ERR "port_accept : failed to get IRQ for "
"telnetd\n");
goto out_free;
@@ -184,8 +183,7 @@ void *port_data(int port_num)
}
if (um_request_irq(ACCEPT_IRQ, fd, IRQ_READ, port_interrupt,
- IRQF_SHARED | IRQF_SAMPLE_RANDOM,
- "port", port)) {
+ IRQF_SHARED, "port", port)) {
printk(KERN_ERR "Failed to get IRQ for port %d\n", port_num);
goto out_close;
}
diff --git a/arch/um/drivers/random.c b/arch/um/drivers/random.c
index b25296e..e32c6aa 100644
--- a/arch/um/drivers/random.c
+++ b/arch/um/drivers/random.c
@@ -131,8 +131,7 @@ static int __init rng_init (void)
random_fd = err;
err = um_request_irq(RANDOM_IRQ, random_fd, IRQ_READ, random_interrupt,
- IRQF_SAMPLE_RANDOM, "random",
- NULL);
+ 0, "random", NULL);
if (err)
goto err_out_cleanup_hw;
diff --git a/arch/um/drivers/xterm_kern.c b/arch/um/drivers/xterm_kern.c
index b68bbe2..e3031e6 100644
--- a/arch/um/drivers/xterm_kern.c
+++ b/arch/um/drivers/xterm_kern.c
@@ -50,8 +50,7 @@ int xterm_fd(int socket, int *pid_out)
init_completion(&data->ready);
err = um_request_irq(XTERM_IRQ, socket, IRQ_READ, xterm_interrupt,
- IRQF_SHARED | IRQF_SAMPLE_RANDOM,
- "xterm", data);
+ IRQF_SHARED, "xterm", data);
if (err) {
printk(KERN_ERR "xterm_fd : failed to get IRQ for xterm, "
"err = %d\n", err);
diff --git a/arch/um/kernel/sigio.c b/arch/um/kernel/sigio.c
index 2a16392..c882111 100644
--- a/arch/um/kernel/sigio.c
+++ b/arch/um/kernel/sigio.c
@@ -25,8 +25,7 @@ int write_sigio_irq(int fd)
int err;
err = um_request_irq(SIGIO_WRITE_IRQ, fd, IRQ_READ, sigio_interrupt,
- IRQF_SAMPLE_RANDOM, "write sigio",
- NULL);
+ 0, "write sigio", NULL);
if (err) {
printk(KERN_ERR "write_sigio_irq : um_request_irq failed, "
"err = %d\n", err);
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 17/17] random: final removal of IRQF_SAMPLE_RANDOM
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
` (15 preceding siblings ...)
2012-07-17 21:32 ` [PATCH 16/17] um: " Theodore Ts'o
@ 2012-07-17 21:32 ` Theodore Ts'o
16 siblings, 0 replies; 30+ messages in thread
From: Theodore Ts'o @ 2012-07-17 21:32 UTC (permalink / raw)
To: Linux Kernel Developers List; +Cc: Theodore Ts'o
The IRQF_SAMPLE_RANDOM flag is finally gone from the kernel tree, only
three years late. :-)
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
Documentation/feature-removal-schedule.txt | 14 --------------
include/linux/interrupt.h | 2 --
2 files changed, 16 deletions(-)
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 56000b3..27f39cf 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -70,20 +70,6 @@ Who: Luis R. Rodriguez <lrodriguez@atheros.com>
---------------------------
-What: IRQF_SAMPLE_RANDOM
-Check: IRQF_SAMPLE_RANDOM
-When: July 2009
-
-Why: Many of IRQF_SAMPLE_RANDOM users are technically bogus as entropy
- sources in the kernel's current entropy model. To resolve this, every
- input point to the kernel's entropy pool needs to better document the
- type of entropy source it actually is. This will be replaced with
- additional add_*_randomness functions in drivers/char/random.c
-
-Who: Robin Getz <rgetz@blackfin.uclinux.org> & Matt Mackall <mpm@selenic.com>
-
----------------------------
-
What: The ieee80211_regdom module parameter
When: March 2010 / desktop catchup
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index e68a8e5..c5f856a 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -42,7 +42,6 @@
*
* IRQF_DISABLED - keep irqs disabled when calling the action handler.
* DEPRECATED. This flag is a NOOP and scheduled to be removed
- * IRQF_SAMPLE_RANDOM - irq is used to feed the random generator
* IRQF_SHARED - allow sharing the irq among several devices
* IRQF_PROBE_SHARED - set by callers when they expect sharing mismatches to occur
* IRQF_TIMER - Flag to mark this interrupt as timer interrupt
@@ -61,7 +60,6 @@
* resume time.
*/
#define IRQF_DISABLED 0x00000020
-#define IRQF_SAMPLE_RANDOM 0x00000040
#define IRQF_SHARED 0x00000080
#define IRQF_PROBE_SHARED 0x00000100
#define __IRQF_TIMER 0x00000200
--
1.7.11.1.108.gb129051
^ permalink raw reply related [flat|nested] 30+ messages in thread