* [PATCH] staging/cptm1217: fix checkpatch warnings
@ 2012-07-16 8:12 Toshiaki Yamane
2012-07-16 8:15 ` Belisko Marek
2012-07-16 8:36 ` Toshiaki Yamane
0 siblings, 2 replies; 4+ messages in thread
From: Toshiaki Yamane @ 2012-07-16 8:12 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel; +Cc: Toshiaki Yamane
The below checkpatch warns was fixed,
drivers/staging/cptm1217/clearpad_tm1217.c:400: WARNING: quoted string split across lines
drivers/staging/cptm1217/cp_tm1217.h:5: ERROR: open brace '{' following struct go on the same line
Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
---
drivers/staging/cptm1217/clearpad_tm1217.c | 4 ++--
drivers/staging/cptm1217/cp_tm1217.h | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cptm1217/clearpad_tm1217.c b/drivers/staging/cptm1217/clearpad_tm1217.c
index 5456f82..59e7e87 100644
--- a/drivers/staging/cptm1217/clearpad_tm1217.c
+++ b/drivers/staging/cptm1217/clearpad_tm1217.c
@@ -396,8 +396,8 @@ static int cp_tm1217_setup_gpio_irq(struct cp_tm1217_device *ts)
retval = gpio_to_irq(ts->gpio);
if (retval < 0) {
- dev_err(ts->dev, "cp_tm1217: GPIO to IRQ failedi,"
- " error %d\n", retval);
+ dev_err(ts->dev, "cp_tm1217: GPIO to IRQ failedi, error %d\n",
+ retval);
gpio_free(ts->gpio);
}
dev_dbg(ts->dev,
diff --git a/drivers/staging/cptm1217/cp_tm1217.h b/drivers/staging/cptm1217/cp_tm1217.h
index a0ce31d..30bad35 100644
--- a/drivers/staging/cptm1217/cp_tm1217.h
+++ b/drivers/staging/cptm1217/cp_tm1217.h
@@ -1,8 +1,7 @@
#ifndef __LINUX_I2C_CP_TM1217_H
#define __LINUX_I2C_CP_TM1217_H
-struct cp_tm1217_platform_data
-{
+struct cp_tm1217_platform_data {
int gpio; /* If not set uses the IRQ resource 0 */
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging/cptm1217: fix checkpatch warnings
2012-07-16 8:12 [PATCH] staging/cptm1217: fix checkpatch warnings Toshiaki Yamane
@ 2012-07-16 8:15 ` Belisko Marek
2012-07-16 8:36 ` Toshiaki Yamane
1 sibling, 0 replies; 4+ messages in thread
From: Belisko Marek @ 2012-07-16 8:15 UTC (permalink / raw)
To: Toshiaki Yamane; +Cc: Greg Kroah-Hartman, devel, linux-kernel
On Mon, Jul 16, 2012 at 10:12 AM, Toshiaki Yamane <yamanetoshi@gmail.com> wrote:
> The below checkpatch warns was fixed,
>
> drivers/staging/cptm1217/clearpad_tm1217.c:400: WARNING: quoted string split across lines
> drivers/staging/cptm1217/cp_tm1217.h:5: ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
> ---
> drivers/staging/cptm1217/clearpad_tm1217.c | 4 ++--
> drivers/staging/cptm1217/cp_tm1217.h | 3 +--
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/cptm1217/clearpad_tm1217.c b/drivers/staging/cptm1217/clearpad_tm1217.c
> index 5456f82..59e7e87 100644
> --- a/drivers/staging/cptm1217/clearpad_tm1217.c
> +++ b/drivers/staging/cptm1217/clearpad_tm1217.c
> @@ -396,8 +396,8 @@ static int cp_tm1217_setup_gpio_irq(struct cp_tm1217_device *ts)
>
> retval = gpio_to_irq(ts->gpio);
> if (retval < 0) {
> - dev_err(ts->dev, "cp_tm1217: GPIO to IRQ failedi,"
> - " error %d\n", retval);
> + dev_err(ts->dev, "cp_tm1217: GPIO to IRQ failedi, error %d\n",
there is also typo (you can fix that as well) ^^^^
> + retval);
> gpio_free(ts->gpio);
> }
> dev_dbg(ts->dev,
> diff --git a/drivers/staging/cptm1217/cp_tm1217.h b/drivers/staging/cptm1217/cp_tm1217.h
> index a0ce31d..30bad35 100644
> --- a/drivers/staging/cptm1217/cp_tm1217.h
> +++ b/drivers/staging/cptm1217/cp_tm1217.h
> @@ -1,8 +1,7 @@
> #ifndef __LINUX_I2C_CP_TM1217_H
> #define __LINUX_I2C_CP_TM1217_H
>
> -struct cp_tm1217_platform_data
> -{
> +struct cp_tm1217_platform_data {
> int gpio; /* If not set uses the IRQ resource 0 */
> };
>
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging/cptm1217: fix checkpatch warnings
2012-07-16 8:12 [PATCH] staging/cptm1217: fix checkpatch warnings Toshiaki Yamane
2012-07-16 8:15 ` Belisko Marek
@ 2012-07-16 8:36 ` Toshiaki Yamane
2012-07-18 1:16 ` Toshiaki Yamane
1 sibling, 1 reply; 4+ messages in thread
From: Toshiaki Yamane @ 2012-07-16 8:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel, marek.belisko; +Cc: Toshiaki Yamane
The below checkpatch warn, error, and typo was fixed,
drivers/staging/cptm1217/clearpad_tm1217.c:400: WARNING: quoted string split across lines
drivers/staging/cptm1217/cp_tm1217.h:5: ERROR: open brace '{' following struct go on the same line
Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
---
drivers/staging/cptm1217/clearpad_tm1217.c | 4 ++--
drivers/staging/cptm1217/cp_tm1217.h | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cptm1217/clearpad_tm1217.c b/drivers/staging/cptm1217/clearpad_tm1217.c
index 5456f82..b154042 100644
--- a/drivers/staging/cptm1217/clearpad_tm1217.c
+++ b/drivers/staging/cptm1217/clearpad_tm1217.c
@@ -396,8 +396,8 @@ static int cp_tm1217_setup_gpio_irq(struct cp_tm1217_device *ts)
retval = gpio_to_irq(ts->gpio);
if (retval < 0) {
- dev_err(ts->dev, "cp_tm1217: GPIO to IRQ failedi,"
- " error %d\n", retval);
+ dev_err(ts->dev, "cp_tm1217: GPIO to IRQ failed, error %d\n",
+ retval);
gpio_free(ts->gpio);
}
dev_dbg(ts->dev,
diff --git a/drivers/staging/cptm1217/cp_tm1217.h b/drivers/staging/cptm1217/cp_tm1217.h
index a0ce31d..30bad35 100644
--- a/drivers/staging/cptm1217/cp_tm1217.h
+++ b/drivers/staging/cptm1217/cp_tm1217.h
@@ -1,8 +1,7 @@
#ifndef __LINUX_I2C_CP_TM1217_H
#define __LINUX_I2C_CP_TM1217_H
-struct cp_tm1217_platform_data
-{
+struct cp_tm1217_platform_data {
int gpio; /* If not set uses the IRQ resource 0 */
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging/cptm1217: fix checkpatch warnings
2012-07-16 8:36 ` Toshiaki Yamane
@ 2012-07-18 1:16 ` Toshiaki Yamane
0 siblings, 0 replies; 4+ messages in thread
From: Toshiaki Yamane @ 2012-07-18 1:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel; +Cc: Toshiaki Yamane
The below checkpatch error was fixed,
drivers/staging/cptm1217/cp_tm1217.h:5: ERROR: open brace '{' following struct go on the same line
Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
---
drivers/staging/cptm1217/cp_tm1217.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/cptm1217/cp_tm1217.h b/drivers/staging/cptm1217/cp_tm1217.h
index a0ce31d..30bad35 100644
--- a/drivers/staging/cptm1217/cp_tm1217.h
+++ b/drivers/staging/cptm1217/cp_tm1217.h
@@ -1,8 +1,7 @@
#ifndef __LINUX_I2C_CP_TM1217_H
#define __LINUX_I2C_CP_TM1217_H
-struct cp_tm1217_platform_data
-{
+struct cp_tm1217_platform_data {
int gpio; /* If not set uses the IRQ resource 0 */
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-18 1:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-16 8:12 [PATCH] staging/cptm1217: fix checkpatch warnings Toshiaki Yamane
2012-07-16 8:15 ` Belisko Marek
2012-07-16 8:36 ` Toshiaki Yamane
2012-07-18 1:16 ` Toshiaki Yamane
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).