From: Michael Ellerman <michael@ellerman.id.au>
To: Matt Evans <matt@ozlabs.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
penberg@kernel.org, kvm-ppc@vger.kernel.org,
prerna@linux.vnet.ibm.com,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
Date: Wed, 18 Jul 2012 12:03:12 +1000 [thread overview]
Message-ID: <1342576992.25827.3.camel@concordia> (raw)
In-Reply-To: <3e2231e9bf466549d1f9b12359f2f8f6@ozlabs.org>
On Tue, 2012-07-17 at 10:33 +0100, Matt Evans wrote:
> Hi Michael,
>
> On 2012-07-17 06:00, Michael Ellerman wrote:
>
> > This is a series for kvmtool that uses a newish kernel API to get
> > MMU info, which is then fed to the guest.
> >
> > Currently we just make a good guess based on the PVR, but that is
> > potentially flakey in a few ways. The most notable is that if you
> > don't
> > specify hugepages we don't boot - because the guest is told we
> > support
> > 16M pages, but we don't really (on HV).
>
> Just had a look, all good. Thanks for tidying some old FIXMEs,
> especially the page/segment DT props encoding grot -- and the designated
> inits in the cpuinfo struct, whew, I heard the scream on IRC. Sorry.
> ;-)
Thanks Matt, no worries about the grot, there was no better way when you
wrote the original code.
The lack of designated inits did bite me quite well, while bisecting I
accidentally dropped the hunk that updated the struct definition but
kept the hunk that changed the initialisation - leading to a VM with a
slb size of 512000000 (tb_freq) etc. :)
cheers
prev parent reply other threads:[~2012-07-18 2:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 5:00 [RFC/PATCH] Use kernel supplied MMU info for kvm tool Michael Ellerman
2012-07-17 5:00 ` [PATCH 01/10] kvm tools: Move mmap_anon_or_hugetblfs() into util Michael Ellerman
2012-07-17 5:00 ` [PATCH 02/10] kvm tools, powerpc: Use mmap_anon_or_hugetblfs() in kvm__arch_init() Michael Ellerman
2012-07-17 5:00 ` [PATCH 03/10] kvm tools: Remember page size as kvm->ram_pagesize Michael Ellerman
2012-07-17 5:00 ` [PATCH 04/10] kvm tools, powerpc: Use designated initializers for struct cpu_info Michael Ellerman
2012-07-17 5:00 ` [PATCH 05/10] kvm tools, powerpc: Use ARRAY_SIZE() in find_cpu_info() Michael Ellerman
2012-07-17 5:00 ` [PATCH 06/10] kvm tools, powerpc: Reformatting " Michael Ellerman
2012-07-17 5:00 ` [PATCH 07/10] kvm tools, powerpc: Restructure find_cpu_info() Michael Ellerman
2012-07-17 5:00 ` [PATCH 08/10] kvm tools, powerpc: Use MMU info from the kernel for ibm,segment-page-sizes Michael Ellerman
2012-07-17 5:00 ` [PATCH 09/10] kvm tools, powerpc: Use MMU info for ibm,processor-segment-sizes Michael Ellerman
2012-07-17 5:00 ` [PATCH 10/10] kvm tools, powerpc: Use MMU info for ibm,slb-size Michael Ellerman
2012-07-17 9:33 ` [RFC/PATCH] Use kernel supplied MMU info for kvm tool Matt Evans
2012-07-17 14:09 ` Pekka Enberg
2012-07-18 2:08 ` Michael Ellerman
2012-07-31 6:22 ` Pekka Enberg
2012-07-18 2:03 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342576992.25827.3.camel@concordia \
--to=michael@ellerman.id.au \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ozlabs.org \
--cc=penberg@kernel.org \
--cc=prerna@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).