From: Axel Lin <axel.lin@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, Graeme Gregory <gg@slimlogic.co.uk>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH RFT 2/2] regulator: palmas: Convert palmas_ops_ldo to [get|set]_voltage_sel_regmap
Date: Wed, 18 Jul 2012 12:26:56 +0800 [thread overview]
Message-ID: <1342585616.28942.2.camel@phoenix> (raw)
In-Reply-To: <1342583395.12515.6.camel@phoenix>
於 三，2012-07-18 於 11:49 +0800，Axel Lin 提到：
> Also remove palmas_ldo_write() function because it is not used after this
> conversion.
Oh. Just found another issue in current code.
Current code in palmas_ldo_init() calls palmas_smps_[read|write]
is wrong. It should call palmas_ldo_[read|write] instead.
And this means palmas_ldo_write() cannot be removed.
To make it easier for review, I'll resend the patches for palmas
as a serial.
Regards,
Axel
prev parent reply other threads:[~2012-07-18 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 3:48 [PATCH RFT 1/2] regulator: palmas: Fix regmap offsets for PALMAS_REG_SMPS10 vsel_reg Axel Lin
2012-07-18 3:49 ` [PATCH RFT 2/2] regulator: palmas: Convert palmas_ops_ldo to [get|set]_voltage_sel_regmap Axel Lin
2012-07-18 4:26 ` Axel Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342585616.28942.2.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).