From: Anton Arapov <anton@redhat.com>
To: Jovi Zhang <bookjovi@gmail.com>
Cc: "Srikar Dronamraju" <srikar@linux.vnet.ibm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH] uprobe: fix misleading log entry
Date: Wed, 18 Jul 2012 17:24:21 +0200 [thread overview]
Message-ID: <1342625061.3295.5.camel@bandura> (raw)
In-Reply-To: <CACV3sbKNmeKqvroYp4C=gna7ht4dvYmrCNA7q9Sa0GfVjx7F_A@mail.gmail.com>
On Wed, 2012-07-18 at 19:43 +0800, Jovi Zhang wrote:
> On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
> <srikar@linux.vnet.ibm.com> wrote:
> > * Jovi Zhang <bookjovi@gmail.com> [2012-07-18 11:08:42]:
> >
> >> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
> >> From: Jovi Zhang <bookjovi@gmail.com>
> >> Date: Wed, 18 Jul 2012 17:51:26 +0800
> >> Subject: [PATCH] uprobe: fix misleading log entry
> >>
> >> There don't have any 'r' prefix in uprobe event naming, remove it.
> >>
> >> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
> >> ---
> >> kernel/trace/trace_uprobe.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> >> index cf382de..852a584 100644
> >> --- a/kernel/trace/trace_uprobe.c
> >> +++ b/kernel/trace/trace_uprobe.c
> >> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> >> if (argv[0][0] == '-')
> >> is_delete = true;
> >> else if (argv[0][0] != 'p') {
> >> - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> >> + pr_info("Probe definition must be started with 'p' or '-'.\n");
> >> return -EINVAL;
> >> }
> >>
> >
> > Yes, uprobes doesnt support return probes. So we should not have
> > mentioned about r.
> Hmm, Does this have specific reason? or just not implemented?
It is not implemented. I'm slowly(very) moving towards it. You are
welcome to take a look.
https://github.com/arapov/linux-aa/commits/uretprobes
Anton.
next prev parent reply other threads:[~2012-07-18 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 3:08 [PATCH] uprobe: fix misleading log entry Jovi Zhang
2012-07-18 9:22 ` Srikar Dronamraju
2012-07-18 11:43 ` Jovi Zhang
2012-07-18 15:24 ` Anton Arapov [this message]
2012-10-12 0:06 ` Jovi Zhang
2012-10-12 4:50 ` Srikar Dronamraju
2012-10-25 14:12 ` Oleg Nesterov
2012-11-19 10:42 ` Steven Rostedt
2012-11-19 12:32 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342625061.3295.5.camel@bandura \
--to=anton@redhat.com \
--cc=bookjovi@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).