* [PATCH 1/3] rtc/rtc-88pm80x: assign ret only when rtc_register_driver fails
@ 2012-07-18 16:40 Devendra Naga
0 siblings, 0 replies; only message in thread
From: Devendra Naga @ 2012-07-18 16:40 UTC (permalink / raw)
To: Andrew Morton, Alessandro Zummo, rtc-linux, linux-kernel; +Cc: Devendra Naga
At the probe we are assigning ret to return value of PTR_ERR right
after the rtc_register_driver, as we would have done it in the
if (IS_ERR(ptr)) check, since the function fails and goes inside
that case
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
drivers/rtc/rtc-88pm80x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c
index a2f956d..7e050b4 100644
--- a/drivers/rtc/rtc-88pm80x.c
+++ b/drivers/rtc/rtc-88pm80x.c
@@ -314,8 +314,8 @@ static int __devinit pm80x_rtc_probe(struct platform_device *pdev)
info->rtc_dev = rtc_device_register("88pm80x-rtc", &pdev->dev,
&pm80x_rtc_ops, THIS_MODULE);
- ret = PTR_ERR(info->rtc_dev);
if (IS_ERR(info->rtc_dev)) {
+ ret = PTR_ERR(info->rtc_dev);
dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
goto out_rtc;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-18 16:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-18 16:40 [PATCH 1/3] rtc/rtc-88pm80x: assign ret only when rtc_register_driver fails Devendra Naga
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).