* [PATCH 3/3] rtc/rtc-da9052: remove unneed devm_kfree call
@ 2012-07-18 16:43 Devendra Naga
0 siblings, 0 replies; only message in thread
From: Devendra Naga @ 2012-07-18 16:43 UTC (permalink / raw)
To: Andrew Morton, Alessandro Zummo, rtc-linux, linux-kernel,
Ashish Jangam, David Dajun Chen
Cc: Devendra Naga
freeing will trigger when driver unloads, so using devm_kfree is
not needed.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
drivers/rtc/rtc-da9052.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c
index da6ab52..7807025 100644
--- a/drivers/rtc/rtc-da9052.c
+++ b/drivers/rtc/rtc-da9052.c
@@ -245,7 +245,7 @@ static int __devinit da9052_rtc_probe(struct platform_device *pdev)
"ALM", rtc);
if (ret != 0) {
rtc_err(rtc->da9052, "irq registration failed: %d\n", ret);
- goto err_mem;
+ return ret;
}
rtc->rtc = rtc_device_register(pdev->name, &pdev->dev,
@@ -259,8 +259,6 @@ static int __devinit da9052_rtc_probe(struct platform_device *pdev)
err_free_irq:
free_irq(rtc->irq, rtc);
-err_mem:
- devm_kfree(&pdev->dev, rtc);
return ret;
}
@@ -271,7 +269,6 @@ static int __devexit da9052_rtc_remove(struct platform_device *pdev)
rtc_device_unregister(rtc->rtc);
free_irq(rtc->irq, rtc);
platform_set_drvdata(pdev, NULL);
- devm_kfree(&pdev->dev, rtc);
return 0;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-18 16:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-18 16:43 [PATCH 3/3] rtc/rtc-da9052: remove unneed devm_kfree call Devendra Naga
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).