From: Joe Perches <joe@perches.com>
To: Toshiaki Yamane <yamanetoshi@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Einon <mark.einon@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/et131x: fix checkpatch warnings
Date: Wed, 18 Jul 2012 10:53:05 -0700 [thread overview]
Message-ID: <1342633985.9551.36.camel@joe2Laptop> (raw)
In-Reply-To: <CAOTypNSvKEfYVLZ=0sN-U+2xiXBO4So4QkvYyKniEFeqvkqVBg@mail.gmail.com>
On Wed, 2012-07-18 at 20:32 +0900, Toshiaki Yamane wrote:
> Thanks for you reply.
>
> I will fix netdev_info only, because I don't know if I should use "%p".
OK, fyi: it turns out ps_ring_physaddr and rx_status_bus
are both dma_addr_t so both should be emitted with %ull
and cast to (unsigned long long) or (u64).
next prev parent reply other threads:[~2012-07-18 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 12:41 [PATCH] staging/et131x: fix checkpatch warnings Toshiaki Yamane
2012-07-18 1:02 ` Toshiaki Yamane
2012-07-18 1:16 ` Joe Perches
2012-07-18 11:32 ` Toshiaki Yamane
2012-07-18 17:53 ` Joe Perches [this message]
2012-07-19 0:05 ` Toshiaki Yamane
2012-07-19 0:10 ` Joe Perches
2012-07-19 0:14 ` Toshiaki Yamane
2012-07-18 11:44 ` Toshiaki Yamane
2012-07-19 1:34 ` Toshiaki Yamane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342633985.9551.36.camel@joe2Laptop \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).