From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754415Ab2GRWM6 (ORCPT ); Wed, 18 Jul 2012 18:12:58 -0400 Received: from g4t0014.houston.hp.com ([15.201.24.17]:18717 "EHLO g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043Ab2GRWM4 (ORCPT ); Wed, 18 Jul 2012 18:12:56 -0400 Message-ID: <1342649293.3010.49.camel@misato.fc.hp.com> Subject: Re: [PATCH 1/4] ACPI: Add acpi_pr_() interfaces From: Toshi Kani To: Joe Perches , ming.m.lin@intel.com Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, isimatu.yasuaki@jp.fujitsu.com, liuj97@gmail.com, srivatsa.bhat@linux.vnet.ibm.com, prarit@redhat.com, imammedo@redhat.com, vijaymohan.pandarathil@hp.com Date: Wed, 18 Jul 2012 16:08:13 -0600 In-Reply-To: <1342648452.2215.12.camel@joe2Laptop> References: <1342644027-19559-1-git-send-email-toshi.kani@hp.com> <1342644027-19559-2-git-send-email-toshi.kani@hp.com> <1342646502.2215.2.camel@joe2Laptop> <1342647682.3010.38.camel@misato.fc.hp.com> <1342648452.2215.12.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-1.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-07-18 at 14:54 -0700, Joe Perches wrote: > On Wed, 2012-07-18 at 15:41 -0600, Toshi Kani wrote: > > On Wed, 2012-07-18 at 14:21 -0700, Joe Perches wrote: > > > On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: > > > > This patch introduces acpi_pr_(), where is a message > > > > level such as err/warn/info, to support improved logging messages > > > > for ACPI, esp. in hotplug operations. acpi_pr_() appends > > > > "ACPI" prefix and ACPI object path to the messages. This improves > > > > diagnostics in hotplug operations since it identifies an object that > > > > caused an issue in a log file. > [] > > > I'd be tempted to instead make the calls more like > > > other _ uses and rename these to > > > acpi_ and change the existing acpi_info to > > > another name. > [] > > I agree with you. Unfortunately, the ACPI CA (ACPI FW interpreter) > > already uses them for its internal-use as follows, so I needed to come > > up with some other name... Hence, acpi_pr_. > > > > /* > > * Error reporting. Callers module and line number are inserted by AE_INFO, > > * the plist contains a set of parens to allow variable-length lists. > > * These macros are used for both the debug and non-debug versions of the code. > > */ > > #define ACPI_INFO(plist) acpi_info plist > > #define ACPI_WARNING(plist) acpi_warning plist > > #define ACPI_EXCEPTION(plist) acpi_exception plist > > #define ACPI_ERROR(plist) acpi_error plist > > #define ACPI_DEBUG_OBJECT(obj,l,i) acpi_ex_do_debug_object(obj,l,i) > > I wouldn't have a problem renaming a few of those to > something like: > > #define ACPI_INFO(plist) acpi_old_info plist > #define ACPI_WARNING(plist) acpi_old_warning plist > #define ACPI_ERROR(plist) acpi_old_error plist > > The acpi folk might though. Hi Joe, ACPI CA is being developed by Intel as OS-neutral code, and is used by multiple OSes including Linux. So, I am not sure how easy to make such changes. I am copying to Lin Ming. > > > Other than that, seems fine to me. > > Great! Can I consider it as Ack? :) > > Fix the kfree first. Please see my other email. Do you think the check should be added despite of the warning message? > I rarely ack stuff as other people generally have to > pick up the changes and I think acks are overrated. That's fair enough. Thanks! -Toshi > cheers, Joe >