Re: [PATCH 0/4] ACPI: hotplug messages improvement

Yasuaki Ishimatsu
2012-07-25T03:46:18Z

Hi Toshi,

2012/07/19 5:40, Toshi Kani wrote:
> This patchset improves logging messages for ACPI CPU, Memory, and
> Container hotplug notify handlers. The patchset introduces a set of
> new macro interfaces, acpi_pr_<level>(), and updates the notify
> handlers to use them. acpi_pr_<level>() appends "ACPI" prefix and
> ACPI object path to the messages. This improves diagnostics in
> hotplug operations since it identifies an object that caused an
> issue in a log file.
>

The log message looks good to me.
But I could not understand when to use it instead of pr_{warn, info, ...}
or ACPI_{WARNING, INFO, ...}. Do you have the policy?

> ---
> This patchset applies on top of the patch below.
>
> [PATCH] ACPI: Add ACPI CPU hot-remove support
> http://marc.info/?l=linux-acpi&m=134098193327362&w=2
>
> ---
> Toshi Kani (4):
> ACPI: Add acpi_pr_<level>() interfaces
> ACPI: Update CPU hotplug messages
> ACPI: Update Memory hotplug messages
> ACPI: Update Container hotplug messages

I think you need update other component, which are driver/acpi/{acpi_pad.c,
battery.c, button.c}. Do you have the plan to update them?

Thanks,
Yasuaki Ishimatsu

> ---
> drivers/acpi/acpi_memhotplug.c | 24 ++++++++++++------------
> drivers/acpi/container.c | 6 +++---
> drivers/acpi/processor_driver.c | 36 +++++++++++++++++++++---------------
> drivers/acpi/utils.c | 32 ++++++++++++++++++++++++++++++++
> include/acpi/acpi_bus.h | 18 ++++++++++++++++++
> 5 files changed, 86 insertions(+), 30 deletions(-)
>