From: Khalid Aziz <khalid.aziz@hp.com>
To: Greg Pearson <greg.pearson@hp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCDP: use early_ioremap/early_iounmap to access pcdp table
Date: Thu, 19 Jul 2012 09:33:22 -0600 [thread overview]
Message-ID: <1342712002.13917.112.camel@lyra> (raw)
In-Reply-To: <1342649974-6860-1-git-send-email-greg.pearson@hp.com>
On Wed, 2012-07-18 at 16:19 -0600, Greg Pearson wrote:
> --- a/drivers/firmware/pcdp.c
> +++ b/drivers/firmware/pcdp.c
> @@ -95,7 +95,7 @@ efi_setup_pcdp_console(char *cmdline)
> if (efi.hcdp == EFI_INVALID_TABLE_ADDR)
> return -ENODEV;
>
> - pcdp = ioremap(efi.hcdp, 4096);
> + pcdp = early_ioremap(efi.hcdp, 4096);
While we are fixing this code up, mapping 4K blindly just does not feel
right to me. Trouble here is that the length of PCDP table is buried in
the header for PCDP table and we can not read it unless we map the table
in. We get the address for PCDP table from the EFI system table which
was mapped in earlier and pointers to various tables were extracted at
that point. So this is a chicken and egg problem. Any ideas if we can do
better than blindly mapping 4K?
--
Khalid Aziz <khalid.aziz@hp.com>
prev parent reply other threads:[~2012-07-19 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 22:19 [PATCH] PCDP: use early_ioremap/early_iounmap to access pcdp table Greg Pearson
2012-07-19 15:27 ` Khalid Aziz
2012-07-19 15:33 ` Khalid Aziz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342712002.13917.112.camel@lyra \
--to=khalid.aziz@hp.com \
--cc=greg.pearson@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox