From: Devendra Naga <develkernel412222@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: "Mikko Virkkilä" <mikko.virkkila@bluegiga.com>,
"Lauri Hintsala" <Lauri.Hintsala@bluegiga.com>,
"Riku Mettälä" <riku.mettala@bluegiga.com>,
"Veli-Pekka Peltola" <veli-pekka.peltola@bluegiga.com>,
"Devendra Naga" <develkernel412222@gmail.com>
Subject: [PATCH 3/3] staging/csr: remove firmware pointer check before giving to release_firmware
Date: Sat, 21 Jul 2012 13:07:17 +0545 [thread overview]
Message-ID: <1342855337-2872-1-git-send-email-develkernel412222@gmail.com> (raw)
we do a check of firmware pointer against the NULL value before we give
it to the release_firmware.
as release_firmware is actually having a check against NULL, its not needed
here.
Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
---
drivers/staging/csr/firmware.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/csr/firmware.c b/drivers/staging/csr/firmware.c
index d14e118..dc6a04d 100644
--- a/drivers/staging/csr/firmware.c
+++ b/drivers/staging/csr/firmware.c
@@ -402,9 +402,7 @@ int uf_release_firmware_files(unifi_priv_t *priv)
int uf_release_firmware(unifi_priv_t *priv, struct dlpriv *to_free)
{
if (to_free != NULL) {
- if (to_free->fw_desc != NULL) {
- release_firmware((const struct firmware *)to_free->fw_desc);
- }
+ release_firmware((const struct firmware *)to_free->fw_desc);
to_free->fw_desc = NULL;
to_free->dl_data = NULL;
to_free->dl_len = 0;
--
1.7.9.5
reply other threads:[~2012-07-21 7:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342855337-2872-1-git-send-email-develkernel412222@gmail.com \
--to=develkernel412222@gmail.com \
--cc=Lauri.Hintsala@bluegiga.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.virkkila@bluegiga.com \
--cc=riku.mettala@bluegiga.com \
--cc=veli-pekka.peltola@bluegiga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox