From: Mike Galbraith <efault@gmx.de>
To: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
mingo@redhat.com, paul@paulmenage.org
Subject: Re: [PATCH 0/5] cpusets: dynamical scheduler domain flags
Date: Mon, 23 Jul 2012 06:28:03 +0200 [thread overview]
Message-ID: <1343017683.7336.67.camel@marge.simpson.net> (raw)
In-Reply-To: <500CB763.9020802@linux.vnet.ibm.com>
On Mon, 2012-07-23 at 10:30 +0800, Michael Wang wrote:
> On 07/21/2012 12:42 AM, Peter Zijlstra wrote:
> > On Tue, 2012-07-17 at 17:03 +0800, Michael Wang wrote:
> >> This patch set provide a way for user to dynamically configure the scheduler
> >> domain flags, which usually to be static.
> >
> > NAK.. you don't get to expose all this nonsense in a 'stable' ABI.
> >
> > You shouldn't need to prod at them to begin with.
>
> So is that means expose those domain flags to user is a bad idea at all?
You can set/clear flags with scripts now, ie domain flags are already
exposed.. as defined by the running kernel.
SD_SHARE_PKG_RESOURCES is a good flag look at. What does flipping that
switch do, and what did it stop doing recently? So yeah, methinks
exporting flags via cpusets is a bad idea. Not only is existence of any
particular flag volatile, functionality behind it is volatile as well,
so having a button to poke does undefined things. (not to mention
non-exclusive sets)
-Mike
next prev parent reply other threads:[~2012-07-23 4:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 9:03 [PATCH 0/5] cpusets: dynamical scheduler domain flags Michael Wang
2012-07-20 16:42 ` Peter Zijlstra
2012-07-23 2:30 ` Michael Wang
2012-07-23 4:28 ` Mike Galbraith [this message]
2012-07-23 4:58 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343017683.7336.67.camel@marge.simpson.net \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@paulmenage.org \
--cc=peterz@infradead.org \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox