From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Ulrich Drepper <drepper@gmail.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 06/12] perf header: Reconstruct group relationship by parsing cmdline
Date: Thu, 26 Jul 2012 00:52:33 +0900 [thread overview]
Message-ID: <1343231553.1525.11.camel@leonhard> (raw)
In-Reply-To: <20120725153932.GE946@krava.brq.redhat.com>
2012-07-25 (수), 17:39 +0200, Jiri Olsa:
> On Tue, Jul 24, 2012 at 06:01:27PM +0900, Namhyung Kim wrote:
> > In order to support the event group viewer, their group relationship
> > is needed. Since it's not recorded explicitly anywhere in the perf.data
> > we should parse saved cmdline and apply the result to the evlist. It is
> > assumed that parsed entries are in a same order with the originals.
> >
> > I know it's fragile but hard to find other way to do it in the current
> > condition. :(
>
> How about storing grouping details in new perf.data feature?
> As you said reparsing looks too fragile.
>
> jirka
Yeah, maybe it's the best thing I can do now.
Thanks,
Namhyung
next prev parent reply other threads:[~2012-07-25 15:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 9:01 [RFC/PATCHSET 00/12] perf report: Add support to event group viewing (v1) Namhyung Kim
2012-07-24 9:01 ` [PATCH 01/12] perf tools: Add a couple of helper routines to handle groups Namhyung Kim
2012-07-24 9:01 ` [PATCH 02/12] perf hist: Convert to struct he_stat Namhyung Kim
2012-07-24 9:01 ` [PATCH 03/12] perf hist: Collapse group hist_entries to a leader Namhyung Kim
2012-07-24 9:01 ` [PATCH 04/12] perf hist: Maintain total periods of group members in the leader Namhyung Kim
2012-07-24 9:01 ` [PATCH 05/12] perf report: Make another loop for output resorting Namhyung Kim
2012-07-24 9:01 ` [PATCH 06/12] perf header: Reconstruct group relationship by parsing cmdline Namhyung Kim
2012-07-25 15:39 ` Jiri Olsa
2012-07-25 15:52 ` Namhyung Kim [this message]
2012-07-24 9:01 ` [PATCH 07/12] perf ui/hist: Add support to group viewing Namhyung Kim
2012-07-24 9:01 ` [PATCH 08/12] perf ui/browser: " Namhyung Kim
2012-07-24 9:01 ` [PATCH 09/12] perf ui/gtk: " Namhyung Kim
2012-07-24 9:01 ` [PATCH 10/12] perf report: Show leader events only when event group is enabled Namhyung Kim
2012-07-24 9:01 ` [PATCH 11/12] perf report: Show group description " Namhyung Kim
2012-07-24 9:01 ` [PATCH 12/12] perf report: Add --group option Namhyung Kim
2012-07-24 9:13 ` [RFC/PATCHSET 00/12] perf report: Add support to event group viewing (v1) Namhyung Kim
2012-07-24 21:17 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343231553.1525.11.camel@leonhard \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=drepper@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox