From: Toshi Kani <toshi.kani@hp.com>
To: Joe Perches <joe@perches.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, bhelgaas@google.com,
isimatu.yasuaki@jp.fujitsu.com, liuj97@gmail.com,
srivatsa.bhat@linux.vnet.ibm.com, prarit@redhat.com,
imammedo@redhat.com, vijaymohan.pandarathil@hp.com
Subject: Re: [PATCH v3 0/4] ACPI: hotplug messages improvement
Date: Wed, 25 Jul 2012 17:34:56 -0600 [thread overview]
Message-ID: <1343259296.3010.424.camel@misato.fc.hp.com> (raw)
In-Reply-To: <1343259112.11398.4.camel@joe2Laptop>
On Wed, 2012-07-25 at 16:31 -0700, Joe Perches wrote:
> On Wed, 2012-07-25 at 17:12 -0600, Toshi Kani wrote:
> > This patchset improves logging messages for ACPI CPU, Memory, and
> > Container hotplug notify handlers. The patchset introduces a set of
> > new macro interfaces, acpi_pr_<level>(), and updates the notify
> > handlers to use them. acpi_pr_<level>() appends "ACPI" prefix and
> > ACPI object path to the messages, and its usage model is similar to
> > dev_<level>(). This improves diagnostics in hotplug operations
> > since it identifies an object that caused an issue in a log file.
> >
> > v3:
> > - Changed acpi_pr_debug() to NOP when !DEBUG and !DYNAMIC_DEBUG.
> > DYNAMIC_DEBUG will be supported later.
> > - Added const to a path variable in acpi_printk().
> > - Added more descriptions to the change log of patch 1/4.
>
> Thanks Toshi.
>
> This seems sensible to me. I've no more comments either.
Thanks Joe for the valuable suggestions!
-Toshi
prev parent reply other threads:[~2012-07-25 23:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 23:12 [PATCH v3 0/4] ACPI: hotplug messages improvement Toshi Kani
2012-07-25 23:12 ` [PATCH v3 1/4] ACPI: Add acpi_pr_<level>() interfaces Toshi Kani
2012-07-26 19:22 ` Bjorn Helgaas
2012-07-26 20:58 ` Toshi Kani
2012-07-26 21:37 ` Bjorn Helgaas
2012-07-26 21:43 ` Joe Perches
2012-07-26 21:50 ` Bjorn Helgaas
2012-07-26 21:57 ` Joe Perches
2012-07-27 3:32 ` Toshi Kani
2012-07-27 3:27 ` Toshi Kani
2012-07-26 21:50 ` Toshi Kani
2012-07-25 23:12 ` [PATCH v3 2/4] ACPI: Update CPU hotplug messages Toshi Kani
2012-07-26 19:23 ` Bjorn Helgaas
2012-07-27 2:39 ` Toshi Kani
2012-07-27 16:05 ` Bjorn Helgaas
2012-07-27 17:18 ` Toshi Kani
2012-07-25 23:12 ` [PATCH v3 3/4] ACPI: Update Memory " Toshi Kani
2012-07-26 19:23 ` Bjorn Helgaas
2012-07-27 2:50 ` Toshi Kani
2012-07-25 23:12 ` [PATCH v3 4/4] ACPI: Update Container " Toshi Kani
2012-07-26 19:23 ` Bjorn Helgaas
2012-07-27 2:52 ` Toshi Kani
2012-07-25 23:31 ` [PATCH v3 0/4] ACPI: hotplug messages improvement Joe Perches
2012-07-25 23:34 ` Toshi Kani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343259296.3010.424.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=bhelgaas@google.com \
--cc=imammedo@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=prarit@redhat.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=vijaymohan.pandarathil@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox