From: Peter Zijlstra <peterz@infradead.org>
To: Alex Shi <alex.shi@intel.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
suresh.b.siddha@intel.com
Subject: Re: [PATCH 2/2] sched: fix a logical error in select_task_rq_fair
Date: Thu, 26 Jul 2012 10:17:11 +0200 [thread overview]
Message-ID: <1343290631.26034.86.camel@twins> (raw)
In-Reply-To: <1343280446-24019-2-git-send-email-alex.shi@intel.com>
On Thu, 2012-07-26 at 13:27 +0800, Alex Shi wrote:
> If find_idlest_cpu() return '-1', and sd->child is NULL. The function
> select_task_rq_fair will return -1. That is not the function's purpose.
But find_idlest_cpu() will only return -1 if the group mask is fully
excluded by the cpus_allowed mask, right?
In that case aren't we covering up a bug in find_idlest_group(), it
appears to have returned a group that isn't eligible to be idlest.
next prev parent reply other threads:[~2012-07-26 8:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 5:27 [PATCH 1/2] sched: recover SD_WAKE_AFFINE in select_task_rq_fair and code clean up Alex Shi
2012-07-26 5:27 ` [PATCH 2/2] sched: fix a logical error in select_task_rq_fair Alex Shi
2012-07-26 8:17 ` Peter Zijlstra [this message]
2012-07-26 9:11 ` Alex Shi
2012-07-27 1:50 ` Alex Shi
2012-07-26 9:37 ` [PATCH 1/2] sched: recover SD_WAKE_AFFINE in select_task_rq_fair and code clean up Mike Galbraith
2012-07-26 9:42 ` Alex Shi
2012-07-27 1:47 ` Alex Shi
2012-07-27 3:22 ` Mike Galbraith
2012-07-27 8:32 ` Peter Zijlstra
2012-07-27 14:42 ` Alex Shi
2012-08-13 12:33 ` Alex Shi
2012-08-13 17:14 ` [tip:sched/core] " tip-bot for Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343290631.26034.86.camel@twins \
--to=peterz@infradead.org \
--cc=alex.shi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).