From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891Ab2G0Bkv (ORCPT ); Thu, 26 Jul 2012 21:40:51 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:57325 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752790Ab2G0Bku (ORCPT ); Thu, 26 Jul 2012 21:40:50 -0400 Message-ID: <1343353248.2271.8.camel@joe2Laptop> Subject: Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings From: Joe Perches To: Toshiaki Yamane Cc: Greg Kroah-Hartman , Andres Salomon , Chris Ball , Jon Nettleton , linux-kernel@vger.kernel.org Date: Thu, 26 Jul 2012 18:40:48 -0700 In-Reply-To: <1343346559-8416-1-git-send-email-yamanetoshi@gmail.com> References: <1343346559-8416-1-git-send-email-yamanetoshi@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote: > Now checkpatch clean. [] > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c [] > @@ -11,6 +11,7 @@ [] > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt [] > @@ -71,18 +72,18 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init) > > ver = dcon_read(dcon, DCON_REG_ID); > if ((ver >> 8) != 0xDC) { > - printk(KERN_ERR "olpc-dcon: DCON ID not 0xDCxx: 0x%04x instead.\n", > - ver); > + pr_err("olpc-dcon: DCON ID not 0xDCxx: 0x%04x instead.\n", > + ver); > rc = -ENXIO; > goto err; > } > > if (is_init) { > - printk(KERN_INFO "olpc-dcon: Discovered DCON version %x\n", > - ver & 0xFF); > + pr_info("olpc-dcon: Discovered DCON version %x\n", > + ver & 0xFF); Hello. Please remove all the embedded "olpc-dcon: " prefixes. There is a pr_fmt define that adds "olpc_dcon" already. You can use the strings program on the output .o files to verify the formats that are produced.