From: Bryan Wu <bryan.wu@canonical.com>
To: gregkh@linuxfoundation.org, ccross@android.com, hmh@hmh.eng.br,
rpurdie@rpsys.net, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: [PATCH 1/3] sysfs: introduce a sysfs_create_file_uevent new API
Date: Fri, 27 Jul 2012 12:02:41 +0800 [thread overview]
Message-ID: <1343361763-10307-2-git-send-email-bryan.wu@canonical.com> (raw)
In-Reply-To: <1343361763-10307-1-git-send-email-bryan.wu@canonical.com>
Send a uevent notification whenever a new sysfs file is created to allow
userspace processes such as udev to modify permissions on the new files.
This new API function helps to do this.
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
fs/sysfs/file.c | 28 ++++++++++++++++++++++++++++
include/linux/sysfs.h | 13 +++++++++++++
2 files changed, 41 insertions(+)
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 00012e3..5a22d13 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -576,6 +576,34 @@ int sysfs_create_file(struct kobject * kobj, const struct attribute * attr)
}
+/**
+ * sysfs_create_file_uevent - create an attribute file for an object
+ and send a uevent to userspace.
+ * @kobj: object we're creating for.
+ * @attr: attribute descriptor.
+ * @desc: description about the uevent.
+ * @action: kobject uevent action type.
+ */
+
+int sysfs_create_file_uevent(struct kobject *kobj, const struct attribute *attr,
+ const char *desc, enum kobject_action action)
+{
+ int err = 0;
+ char *envp[2];
+
+ BUG_ON(!kobj || !kobj->sd || !attr || !desc);
+
+ err = sysfs_add_file(kobj->sd, attr, SYSFS_KOBJ_ATTR);
+
+ if (desc) {
+ envp[0] = desc;
+ envp[1] = NULL;
+ kobject_uevent_env(kobj, action, envp);
+ }
+
+ return err;
+}
+
int sysfs_create_files(struct kobject *kobj, const struct attribute **ptr)
{
int err = 0;
diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 381f06d..0054d41 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -22,6 +22,7 @@
struct kobject;
struct module;
enum kobj_ns_type;
+enum kobject_action;
struct attribute {
const char *name;
@@ -142,6 +143,10 @@ int __must_check sysfs_move_dir(struct kobject *kobj,
int __must_check sysfs_create_file(struct kobject *kobj,
const struct attribute *attr);
+int __must_check sysfs_create_file_uevent(struct kobject * kobj,
+ const struct attribute * attr,
+ const char * desc,
+ enum kobject_action action);
int __must_check sysfs_create_files(struct kobject *kobj,
const struct attribute **attr);
int __must_check sysfs_chmod_file(struct kobject *kobj,
@@ -226,6 +231,14 @@ static inline int sysfs_create_file(struct kobject *kobj,
return 0;
}
+static inline int sysfs_create_file_uevent(struct kobject * kobj,
+ const struct attribute * attr,
+ const char *desc,
+ enum kobject_action action)
+{
+ return 0;
+}
+
static inline int sysfs_create_files(struct kobject *kobj,
const struct attribute **attr)
{
--
1.7.11.1
next prev parent reply other threads:[~2012-07-27 4:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 4:02 [PATCH 0/3] add new API to sysfs and device core code Bryan Wu
2012-07-27 4:02 ` Bryan Wu [this message]
2012-07-27 15:52 ` [PATCH 1/3] sysfs: introduce a sysfs_create_file_uevent new API Greg KH
2012-07-28 15:18 ` Bryan Wu
2012-07-27 4:02 ` [PATCH 2/3] drivers: add a new device_create_file_uevent API Bryan Wu
2012-07-27 4:02 ` [PATCH 3/3] ledtrig-timer: convert to use " Bryan Wu
2012-07-27 15:50 ` [PATCH 0/3] add new API to sysfs and device core code Greg KH
2012-07-27 19:38 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343361763-10307-2-git-send-email-bryan.wu@canonical.com \
--to=bryan.wu@canonical.com \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).