linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel J Blueman <daniel@quora.org>
To: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sarah Sharp <sarah.a.sharp@linux.intel.com>,
	Daniel J Blueman <daniel@quora.org>
Subject: [PATCH] Add Etron XHCI quirk to avoid warning spam
Date: Fri, 27 Jul 2012 12:03:44 +0800	[thread overview]
Message-ID: <1343361824-11417-1-git-send-email-daniel@quora.org> (raw)

When various USB3 devices with Etron XHCI controllers, we see a bunch of
warnings:
xhci_hcd 0000:02:00.0: WARN Successful completion on short TX: needs
XHCI_TRUST_TX_LENGTH quirk?

Acknowledge the issue by adding the quirk.

Signed-off-by: Daniel J Blueman <daniel@quora.org>
---
 drivers/usb/host/xhci-pci.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 18b231b..715ad11 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -95,10 +95,13 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		xhci->limit_active_eps = 64;
 		xhci->quirks |= XHCI_SW_BW_CHECKING;
 	}
-	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
-			pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-		xhci->quirks |= XHCI_RESET_ON_RESUME;
-		xhci_dbg(xhci, "QUIRK: Resetting on resume\n");
+	if (pdev->vendor == PCI_VENDOR_ID_ETRON) {
+		xhci->quirks |= XHCI_TRUST_TX_LENGTH;
+
+		if (pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
+			xhci->quirks |= XHCI_RESET_ON_RESUME;
+			xhci_dbg(xhci, "QUIRK: Resetting on resume\n");
+		}
 	}
 	if (pdev->vendor == PCI_VENDOR_ID_VIA)
 		xhci->quirks |= XHCI_RESET_ON_RESUME;
-- 
1.7.9.5


             reply	other threads:[~2012-07-27  4:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27  4:03 Daniel J Blueman [this message]
2012-07-27  6:14 ` [PATCH] Add Etron XHCI quirk to avoid warning spam Sarah Sharp
2012-07-27  6:40   ` Daniel J Blueman
2012-07-27 17:10     ` Sarah Sharp
2012-07-30  8:52       ` Daniel J Blueman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343361824-11417-1-git-send-email-daniel@quora.org \
    --to=daniel@quora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).