From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752566Ab2G0R5B (ORCPT ); Fri, 27 Jul 2012 13:57:01 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:62184 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472Ab2G0R46 (ORCPT ); Fri, 27 Jul 2012 13:56:58 -0400 From: Joonsoo Kim To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim , Christoph Lameter Subject: [RESEND PATCH 1/4 v3] mm: correct return value of migrate_pages() and migrate_huge_pages() Date: Sat, 28 Jul 2012 02:55:00 +0900 Message-Id: <1343411703-2720-1-git-send-email-js1304@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org migrate_pages() should return number of pages not migrated or error code. When unmap_and_move return -EAGAIN, outer loop is re-execution without initialising nr_failed. This makes nr_failed over-counted. So this patch correct it by initialising nr_failed in outer loop. migrate_huge_pages() is identical case as migrate_pages() Signed-off-by: Joonsoo Kim Cc: Christoph Lameter Acked-by: Christoph Lameter Acked-by: Michal Nazarewicz --- [Patch 2/4]: add "Acked-by: Michal Nazarewicz " [Patch 3/4]: commit log is changed according to Michal Nazarewicz's suggestion. There is no other change from v2. Just resend as ping for Andrew. diff --git a/mm/migrate.c b/mm/migrate.c index be26d5c..f495c58 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -982,6 +982,7 @@ int migrate_pages(struct list_head *from, for(pass = 0; pass < 10 && retry; pass++) { retry = 0; + nr_failed = 0; list_for_each_entry_safe(page, page2, from, lru) { cond_resched(); @@ -1029,6 +1030,7 @@ int migrate_huge_pages(struct list_head *from, for (pass = 0; pass < 10 && retry; pass++) { retry = 0; + nr_failed = 0; list_for_each_entry_safe(page, page2, from, lru) { cond_resched(); -- 1.7.9.5