From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754929Ab2GaCWI (ORCPT ); Mon, 30 Jul 2012 22:22:08 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:44983 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476Ab2GaCWG (ORCPT ); Mon, 30 Jul 2012 22:22:06 -0400 Message-ID: <1343701316.7557.1.camel@phoenix> Subject: Re: [PATCH] regulator: core: Add intermediate cast to uintptr_t before casting to pointer From: Axel Lin To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org Date: Tue, 31 Jul 2012 10:21:56 +0800 In-Reply-To: <20120730153309.GK4468@opensource.wolfsonmicro.com> References: <1343605633.11323.1.camel@phoenix> <20120730153309.GK4468@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 於 一，2012-07-30 於 16:33 +0100，Mark Brown 提到： > On Mon, Jul 30, 2012 at 07:47:13AM +0800, Axel Lin wrote: > > > _notifier_call_chain(rdev, REGULATOR_EVENT_VOLTAGE_CHANGE, > > - (void *)best_val); > > + (void *)(uintptr_t)best_val); > > This also looks problematic, you should never need to cast a pointer to > or from void. If I remove the cast to (void *), I got below build warning: CC drivers/regulator/core.o drivers/regulator/core.c: In function '_regulator_do_set_voltage': drivers/regulator/core.c:2183:10: warning: passing argument 3 of '_notifier_call_chain' makes pointer from integer without a cast [enabled by default] drivers/regulator/core.c:94:13: note: expected 'void *' but argument is of type 'long unsigned int' ( Sorry, I forgot to reply-all so I send the mail again ) Axel