public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: George Spelvin <linux@horizon.com>
To: vda.linux@googlemail.com, mina86@mina86.com
Cc: hughd@google.com, linux-kernel@vger.kernel.org, linux@horizon.com
Subject: [PATCH 3/4] lib: vsprintf: Optimize put_dec_trunc8
Date: Fri,  3 Aug 2012 01:21:10 -0400	[thread overview]
Message-ID: <1343971271-13355-3-git-send-email-linux@horizon.com> (raw)
In-Reply-To: <1343971271-13355-1-git-send-email-linux@horizon.com>

If you're going to have a conditional branch after
each 32x32->64-bit multiply, might as well shrink the code
and make it a loop.

This also avoids using the long multiply for small integers.

(This leaves the comments in a confusing state, but that's a separate
patch to make review easier.)

Signed-off-by: George Spelvin <linux@horizon.com>
---
 lib/vsprintf.c |   20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index a8e7392..3ca77b8 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -174,20 +174,12 @@ char *put_dec_trunc8(char *buf, unsigned r)
 	unsigned q;
 
 	/* Copy of previous function's body with added early returns */
-	q      = (r * (uint64_t)0x1999999a) >> 32;
-	*buf++ = (r - 10 * q) + '0'; /* 2 */
-	if (q == 0)
-		return buf;
-	r      = (q * (uint64_t)0x1999999a) >> 32;
-	*buf++ = (q - 10 * r) + '0'; /* 3 */
-	if (r == 0)
-		return buf;
-	q      = (r * (uint64_t)0x1999999a) >> 32;
-	*buf++ = (r - 10 * q) + '0'; /* 4 */
-	if (q == 0)
-		return buf;
-	r      = (q * (uint64_t)0x1999999a) >> 32;
-	*buf++ = (q - 10 * r) + '0'; /* 5 */
+	while (r >= 10000) {
+		q = r + '0';
+		r  = (r * (uint64_t)0x1999999a) >> 32;
+		*buf++ = q - 10*r;
+	}
+
 	if (r == 0)
 		return buf;
 	q      = (r * 0x199a) >> 16;
-- 
1.7.10.4


  parent reply	other threads:[~2012-08-03  5:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03  5:21 [PATCH 1/4] lib: vsprintf: Optimize division by 10 for small integers George Spelvin
2012-08-03  5:21 ` [PATCH 2/4] lib: vsprintf: Optimize division by 10000 George Spelvin
2012-09-23 17:30   ` Michal Nazarewicz
2012-09-24 12:16     ` George Spelvin
2012-09-24 12:41       ` Michal Nazarewicz
2012-09-24 13:56         ` George Spelvin
2012-09-24 15:14           ` Geert Uytterhoeven
2012-09-24 15:48             ` George Spelvin
2012-09-24  9:03   ` Denys Vlasenko
2012-09-24 12:35     ` George Spelvin
2012-09-24 15:02       ` Denys Vlasenko
2012-08-03  5:21 ` George Spelvin [this message]
2012-09-23 14:18   ` [PATCH 3/4] lib: vsprintf: Optimize put_dec_trunc8 Rabin Vincent
2012-09-24 11:13     ` George Spelvin
2012-09-24 14:33     ` George Spelvin
2012-09-24 14:53       ` Michal Nazarewicz
2012-09-24 14:57         ` Michal Nazarewicz
2012-09-23 18:22   ` Michal Nazarewicz
2012-09-24 11:46     ` George Spelvin
2012-09-24 12:29       ` Michal Nazarewicz
2012-09-24 13:49         ` George Spelvin
2012-09-24 15:06           ` Michal Nazarewicz
2012-09-25 11:44           ` George Spelvin
2012-09-25 13:00             ` Denys Vlasenko
2012-08-03  5:21 ` [PATCH 4/4] lib: vsprintf: Fix broken comments George Spelvin
2012-09-23 17:22 ` [PATCH 1/4] lib: vsprintf: Optimize division by 10 for small integers Michal Nazarewicz
2012-09-24 14:18   ` George Spelvin
2012-09-24  9:06 ` Denys Vlasenko
2012-09-24 11:27   ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343971271-13355-3-git-send-email-linux@horizon.com \
    --to=linux@horizon.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mina86@mina86.com \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox