From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
Anton Blanchard <anton@au1.ibm.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: Is iommu_num_pages() broken ?
Date: Sun, 05 Aug 2012 16:49:56 +1000 [thread overview]
Message-ID: <1344149396.24037.86.camel@pasglop> (raw)
In-Reply-To: <m24nohsuz8.fsf@linux-m68k.org>
On Sun, 2012-08-05 at 08:39 +0200, Andreas Schwab wrote:
> addr & (io_page_size - 1) computes the offset into the page pointed to
> by addr. Looks right to me.
>
> addr & ~(io_page_size - 1) would round addr down to the start of the
> page.
Ah that's right, for some reason I'm so used to seeing ~ before such
constructs that my brain must have imagined it :-)
Sorry for the noise. Next time I'll have coffee first then re-check ...
Cheers,
Ben.
prev parent reply other threads:[~2012-08-05 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 0:16 Is iommu_num_pages() broken ? Benjamin Herrenschmidt
2012-08-05 6:39 ` Andreas Schwab
2012-08-05 6:49 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344149396.24037.86.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@au1.ibm.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox