From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Pekka Enberg <penberg@kernel.org>
Subject: [PATCH 0/7] perf hists: Cleanup hist printing code (v2)
Date: Mon, 6 Aug 2012 17:57:35 +0900 [thread overview]
Message-ID: <1344243462-28403-1-git-send-email-namhyung@kernel.org> (raw)
Hi,
This is a cleanup and refactoring patchset for the hist printing code
by adding hist_period_print functions and hpp_context. I believe it
makes the code easy to maintain and to add new functionalities like
upcoming group viewing and callchain accumulation.
Any comments are welcome, thanks.
Namhyung
Namhyung Kim (7):
perf hists: Separate out hist print functions
perf hists: Refactor some functions
perf hists: Introduce hist_period_print functions
perf hists: Handle field separator properly
perf hists: Use hpp_functions->width to calculate the column widths
perf ui/browser: Use hist_period_print functions
perf gtk/browser: Use hist_period_print functions
tools/perf/Makefile | 4 +-
tools/perf/builtin-diff.c | 1 +
tools/perf/ui/browsers/hists.c | 96 +++--
tools/perf/ui/gtk/browser.c | 101 ++++-
tools/perf/ui/gtk/gtk.h | 2 +
tools/perf/ui/gtk/setup.c | 1 +
tools/perf/ui/hist.c | 885 +++++++++++++++++++++++++++++++++++++++++
tools/perf/ui/setup.c | 8 +-
tools/perf/ui/tui/setup.c | 4 +
tools/perf/util/hist.c | 710 +--------------------------------
tools/perf/util/hist.h | 41 +-
11 files changed, 1115 insertions(+), 738 deletions(-)
create mode 100644 tools/perf/ui/hist.c
--
1.7.11.2
next reply other threads:[~2012-08-06 9:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 8:57 Namhyung Kim [this message]
2012-08-06 8:57 ` [PATCH 1/7] perf hists: Separate out hist print functions Namhyung Kim
2012-08-09 19:18 ` Arnaldo Carvalho de Melo
2012-08-10 3:08 ` Namhyung Kim
2012-08-06 8:57 ` [PATCH 2/7] perf hists: Refactor some functions Namhyung Kim
2012-08-06 8:57 ` [PATCH 3/7] perf hists: Introduce hist_period_print functions Namhyung Kim
2012-08-06 8:57 ` [PATCH 4/7] perf hists: Handle field separator properly Namhyung Kim
2012-08-06 8:57 ` [PATCH 5/7] perf hists: Use hpp_functions->width to calculate the column widths Namhyung Kim
2012-08-06 8:57 ` [PATCH 6/7] perf ui/browser: Use hist_period_print functions Namhyung Kim
2012-08-06 8:57 ` [PATCH 7/7] perf gtk/browser: " Namhyung Kim
2012-08-15 10:48 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344243462-28403-1-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox