Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"

Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"

[Cyrill Gorcunov]

On Fri, Aug 03, 2012 at 03:29:53PM +0200, Richard Weinberger wrote:
> get_robust_list has at least two valid use cases.
> 1. checkpoint/restore in userspace
> 2. post mortem analysis
> 
> Cc: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Darren Hart <dvhart@linux.intel.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
> Cc: kernel-hardening@lists.openwall.com
> Cc: spender@grsecurity.net
> Cc: keescook@chromium.org
> Cc: tglx@linutronix.de
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: xemul@parallels.com
> Cc: <stable@vger.kernel.org> # 3.4.x
> Cc: <stable@vger.kernel.org> # 3.5.x
> Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---

Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>

Thanks, Richard!

Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"

[richard -rw- weinberger]

On Fri, Aug 3, 2012 at 3:34 PM, Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> On Fri, Aug 03, 2012 at 03:29:53PM +0200, Richard Weinberger wrote:
>> get_robust_list has at least two valid use cases.
>> 1. checkpoint/restore in userspace
>> 2. post mortem analysis
>>
>> Cc: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: Darren Hart <dvhart@linux.intel.com>
>> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
>> Cc: Jiri Kosina <jkosina@suse.cz>
>> Cc: Eric W. Biederman <ebiederm@xmission.com>
>> Cc: David Howells <dhowells@redhat.com>
>> Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
>> Cc: kernel-hardening@lists.openwall.com
>> Cc: spender@grsecurity.net
>> Cc: keescook@chromium.org
>> Cc: tglx@linutronix.de
>> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
>> Cc: xemul@parallels.com
>> Cc: <stable@vger.kernel.org> # 3.4.x
>> Cc: <stable@vger.kernel.org> # 3.5.x
>> Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>
> Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
>
> Thanks, Richard!

Looks like the patch itself did made into through vger.
Will resend later.

-- 
Thanks,
//richard

Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"

[Kees Cook]

On Fri, Aug 3, 2012 at 6:29 AM, Richard Weinberger <richard@nod.at> wrote:
> get_robust_list has at least two valid use cases.
> 1. checkpoint/restore in userspace
> 2. post mortem analysis
>
> Cc: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Darren Hart <dvhart@linux.intel.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
> Cc: kernel-hardening@lists.openwall.com
> Cc: spender@grsecurity.net
> Cc: keescook@chromium.org
> Cc: tglx@linutronix.de
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: xemul@parallels.com
> Cc: <stable@vger.kernel.org> # 3.4.x
> Cc: <stable@vger.kernel.org> # 3.5.x
> Link: http://lkml.kernel.org/r/CAFLxGvzPVPyXPwjay4a01q1vx4K4Ht56bHjzswYrr1wvB_1dYw%20%28%29%20mail%20!%20gmail%20!%20com
> Signed-off-by: Richard Weinberger <richard@nod.at>

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook
Chrome OS Security

Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"

[Peter Zijlstra]

On Fri, 2012-08-03 at 15:29 +0200, Richard Weinberger wrote:
> get_robust_list has at least two valid use cases.
> 1. checkpoint/restore in userspace
> 2. post mortem analysis 

Shouldn't this then also be added as a comment somewhere near the
implementation to avoid a repeat of this deprecate / undeprecate cycle?

Re: [PATCH] Revert "futex: Mark get_robust_list as deprecated"

[Richard Weinberger]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Am 06.08.2012 16:53, schrieb Peter Zijlstra:
> On Fri, 2012-08-03 at 15:29 +0200, Richard Weinberger wrote:
>> get_robust_list has at least two valid use cases.
>> 1. checkpoint/restore in userspace
>> 2. post mortem analysis 
> 
> Shouldn't this then also be added as a comment somewhere near the
> implementation to avoid a repeat of this deprecate / undeprecate cycle?

Or someone submits a patch to glibc and the man-pages project to make this
system call official...

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]