From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Russell King <rmk@arm.linux.org.uk>,
sameo@linux.intel.com, rpurdie@rpsys.net, bryan.wu@canonical.com,
linux-kernel@vger.kernel.org, Bergmann Arnd <arnd@arndb.de>
Subject: Re: [PATCH 0/5] mfd: replace IORESOURCE_IO by IORESOURCE_MEM
Date: Tue, 07 Aug 2012 18:24:17 +1000 [thread overview]
Message-ID: <1344327857.2698.16.camel@pasglop> (raw)
In-Reply-To: <CAN1soZzSz9Gs_SsTd_5BOFNjUviZgBjBiGCjt1EsAtkS5XquQA@mail.gmail.com>
On Tue, 2012-08-07 at 09:47 +0800, Haojian Zhuang wrote:
> > Whoever looks at this would need to do some detective work, it does
> seem
> > like there must have been a reason to use a bitmask here...
>
> Changing bitmask to a value for IORESOURCE type is a risk. I agree on
> Mark
> that someone will complain on this.
>
> Could we consider to expand the usage of IORESOURCE_IO? Maybe we can
> use it for both ISA/PCI and IO related in chip.
No, I agree with Russell. I would suggest changing the bitmask.
However this can be done painlessly since the existing types don't
change value so the existing code that checks bits is still correct
in all cases we care about.
Cheers,
Ben.
next prev parent reply other threads:[~2012-08-07 8:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 16:32 [PATCH 0/5] mfd: replace IORESOURCE_IO by IORESOURCE_MEM Haojian Zhuang
2012-08-05 16:32 ` [PATCH 1/5] mfd: use IORESOURCE_MEM in 88pm860x backlight Haojian Zhuang
2012-08-05 16:32 ` [PATCH 2/5] mfd: use IORESOUCE_MEM in 88pm860x leds driver Haojian Zhuang
2012-08-05 16:32 ` [PATCH 3/5] mfd: use IORESOURCE_MEM in 88pm860x regulator Haojian Zhuang
2012-08-05 16:32 ` [PATCH 4/5] mfd: avoid to return failure in 88pm860x Haojian Zhuang
2012-08-05 16:32 ` [PATCH 5/5] ARM: mmp: enable 88pm860x in ttc dkb Haojian Zhuang
2012-08-06 14:30 ` [PATCH 0/5] mfd: replace IORESOURCE_IO by IORESOURCE_MEM Mark Brown
2012-08-06 14:42 ` Haojian Zhuang
2012-08-06 15:46 ` Mark Brown
2012-08-06 15:56 ` Haojian Zhuang
2012-08-06 15:58 ` Mark Brown
2012-08-06 19:22 ` Russell King
2012-08-06 19:53 ` Mark Brown
2012-08-06 21:31 ` Russell King
2012-08-06 22:00 ` Mark Brown
2012-08-07 1:47 ` Haojian Zhuang
2012-08-07 7:58 ` Russell King
2012-08-07 8:24 ` Benjamin Herrenschmidt [this message]
2012-08-07 10:38 ` Mark Brown
2012-08-07 11:13 ` Russell King
2012-08-07 11:28 ` Mark Brown
2012-08-07 11:31 ` Russell King
2012-08-07 11:36 ` Russell King
2012-08-07 11:45 ` Mark Brown
2012-08-07 11:51 ` Russell King
2012-08-07 12:58 ` Mark Brown
2012-08-07 13:47 ` Russell King
2012-08-07 15:54 ` Mark Brown
2012-08-07 15:22 ` Geert Uytterhoeven
2012-08-07 15:44 ` Russell King
2012-08-07 16:48 ` Mark Brown
2012-08-07 20:51 ` Arnd Bergmann
2012-08-07 11:38 ` Mark Brown
2012-08-07 11:44 ` Russell King
2012-08-07 12:11 ` Russell King
2012-08-07 13:25 ` Mark Brown
2012-08-07 14:28 ` Arnd Bergmann
2012-08-07 14:41 ` Russell King
2012-08-07 16:36 ` Mark Brown
2012-08-07 8:22 ` Benjamin Herrenschmidt
2012-08-07 8:28 ` Russell King
2012-08-07 11:28 ` Arnd Bergmann
2012-08-07 11:32 ` Russell King
2012-08-07 11:34 ` Arnd Bergmann
2012-08-07 11:35 ` Mark Brown
2012-08-07 11:41 ` Russell King
2012-08-07 15:45 ` Alan Cox
2012-08-07 15:50 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344327857.2698.16.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=bryan.wu@canonical.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox