From: Joe Perches <joe@perches.com>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: ebiederm@xmission.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to
Date: Tue, 07 Aug 2012 09:10:07 -0700 [thread overview]
Message-ID: <1344355807.2026.41.camel@joe2Laptop> (raw)
In-Reply-To: <20120807145738.GA5175@debian.Jeff>
On Tue, 2012-08-07 at 20:27 +0530, Jeffrin Jose wrote:
> / Is putting "rc = put_user(amount, (int __user *)argp);" on the same
> / indentation level as "amount = skb->len - sizeof(struct ddpehdr);"
> / really what you want to do?
> No. I was trying to place those lines at one
> indentation back from their current position.
If you are using checkpatch as a guide, run
"./scripts/checkpatch.pl -f --strict net/appletalk/ddp.c"
after you patch it and also correct any problems found in
the area you want to update too.
A second option is to use emacs with the proper linux
style indentation.
(See: Documentation/CodingStyle, Chapter 9: You've made a mess of it)
Another option is not to patch the file at all.
Also, don't submit multiple patches, resubmit 1 single patch
with all the appropriate corrections.
next prev parent reply other threads:[~2012-08-07 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 14:57 [PATCH] net:appletalk:ddp:fixed coding style issue again relating to Jeffrin Jose
2012-08-07 16:10 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-07 14:00 Jeffrin Jose
2012-08-07 14:25 ` Eric W. Biederman
2012-08-07 21:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344355807.2026.41.camel@joe2Laptop \
--to=joe@perches.com \
--cc=ahiliation@yahoo.co.in \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox