Re: [tip:x86/platform] x86: Add TS-5500 platform support

[Vivien Didelot <vivien.didelot@savoirfairelinux.com>]

Hi Ingo,

> This patch still appears to have some problems with certain
> (rare) LEDS .config variations:
> 
>  arch/x86/built-in.o: In function `ts5500_init':
>  ts5500.c:(.init.text+0xdae6): undefined reference to
>  `led_classdev_register'
> 
> Config attached.
> 
> Please fix & resend.

I think the attached config might not be the right one. This issue
happens when the ts5500 support is selected (CONFIG_TS5500=y) but
the LED class (CONFIG_NEW_LEDS and CONFIG_LEDS_CLASS) is not.

Thanks for pointing this out.
The following patch below solves this issue. Is it ok, or should
I resend to whole board support patch?

Thanks,
Vivien

--------


diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index df5815e..9394759 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2191,6 +2191,8 @@ config TS5500
        bool "Technologic Systems TS-5500 platform support"
        depends on MELAN
        select CHECK_SIGNATURE
+       select NEW_LEDS
+       select LEDS_CLASS
        ---help---
          This option enables system support for the Technologic Systems TS-5500.