From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759082AbcAUJYS (ORCPT ); Thu, 21 Jan 2016 04:24:18 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:41781 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758305AbcAUJYM (ORCPT ); Thu, 21 Jan 2016 04:24:12 -0500 X-AuditID: cbfee68e-f793c6d00000136c-85-56a0a3ba157d Date: Thu, 21 Jan 2016 09:24:10 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH] PM / devfreq: tegra: Set freq in rate callback To: Tomeu Vizoso , "linux-kernel@vger.kernel.org" Cc: Tyler Baker , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= , Stephen Warren , Thierry Reding , Alexandre Courbot , "linux-pm@vger.kernel.org" , "linux-tegra@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20160121092322698@myungjoo.ham Msgkey: 20160121092322698@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20160121092322698@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <1344895371.241491453368249580.JavaMail.weblogic@ep2mlwas01b> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkSHfX4gVhBtubeS0u75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAldGY88ZpoI7XBX7rx1kbGDcwtXFyMkhJKAusWjJSTYQW0LARKJj eQMjhC0mceHeeqA4F1DNUkaJX7sPwRWtuvWbBSIxh1Hi7KUDYAkWAVWJ6e+/sncxcnCwCehJ zPycDBIWFnCW+HzoEDuILSJQIHF46VmwocwCH5gknv7/xgZxhZLEmn2vWEBsXgFBiZMzn7BA LFOV+DZ1EzPITF4BNYmb/aUQYXGJC3MvsUPYvBIz2p9ClctJTPu6hhnClpY4P2sD3DOLvz+G ivNLHLu9gwnCFpCYeuYgVI2WxNEl96HifBJrFr5lganfdWo5M8yu+1vmQtVISGxtecIKYjML KEpM6X4I9jqzgKbE+l366D7hFfAEhtQ3RpDXJQSmckh8mHyXcQKj0iwkdbOQjJqFMApZyQJG llWMoqkFyQXFSelFRnrFibnFpXnpesn5uZsYgWnh9L9nfTsYbx6wPsQowMGoxMN749r8MCHW xLLiytxDjKbASJrILCWanA9MPnkl8YbGZkYWpiamxkbmlmZK4rwJUj+DhQTSE0tSs1NTC1KL 4otKc1KLDzEycXBKNTDKrYsobtXbKO8YzHbONqXFKev3ZkPveY16gr1vV4udPZ1VuiaY33TG bke2pX9n3kjXsmtvz/nYHBDWN6e8Z8ON/2e33wi9t7uaObBRjXNyyN8MQbll2mmmt7Zc2yax /dOM8x17y9bMyV6XIFr9Yd0l9ae+a5y0xV7sW/SIo9z41wbLwrIHzw4rsRRnJBpqMRcVJwIA QQ2BYAYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/tft1dixeEGTy/y2FxedccNgdGj8+b 5AIYo9JsMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4CG KimUJeaUAoUCEouLlfTtbIryS0tSFTLyi0tslaINzY30jAz0TI30DI1jrQwNDIxMgWoS0jIa e84wFdzhqth/7SBjA+MWri5GTg4hAXWJRUtOsoHYEgImEqtu/WaBsMUkLtxbDxTnAqqZwyhx 9tIBsCIWAVWJ6e+/sncxcnCwCehJzPycDBIWFnCW+HzoEDuILSJQIHF46VmwXmaBD0wST/9/ Y4NYpiSxZt8rsAW8AoISJ2c+gVqmKvFt6iZmkJm8AmoSN/tLIcLiEhfmXmKHsHklZrQ/hSqX k5j2dQ0zhC0tcX7WBkaYmxd/fwwV55c4dnsHE4QtIDH1zEGoGi2Jo0vuQ8X5JNYsfMsCU7/r 1HJmmF33t8yFqpGQ2NryhBXEZhZQlJjS/RDsdWYBTYn1u/TRfcIr4AkMqW+MExhlZyFJzULS PQuhG1nJAkaWVYyiqQXJBcVJ6RXGesWJucWleel6yfm5mxjBKejZ4h2M/89bH2IU4GBU4uHd GbAgTIg1say4MvcQowQHs5IIr5wKUIg3JbGyKrUoP76oNCe1+BCjKTDKJjJLiSbnA9NjXkm8 obGxiZmJqaWJhYGpuZI47+19fmFCAumJJanZqakFqUUwfUwcnFINjNJnFi/4GFUlxftBo2yJ m0CYwf/jmgduX/Du4XSwunF/2ZHDXEquLS+ul8rP8zx2r/mkWaYaQ93jK01cjru/CvQ7qv7a dP/0WdOv+j0Fu/Z1zOcKcDSfWbbzkVTbmjNfpuz8e7xz3u6b68zERPRvzD/9NCDk/dt722/x 3gqomW1ilOlx0G9DUJASS3FGoqEWc1FxIgDbPV0jVwMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u0L9OOGe030927 >As per the documentation of the devfreq_dev_profile.target callback, set >the freq argument to the new frequency before returning. > >This caused endless messages like this after recent changes in the core: > >devfreq 6000c800.actmon: Couldn't update frequency transition information. > >Signed-off-by: Tomeu Vizoso >Reported-by: Tyler Baker Ah.. this is critical and material for LTS queue. Signed-off-by: MyungJoo Ham >--- > drivers/devfreq/tegra-devfreq.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >index 848b93ee930f..fe9dce0245bf 100644 >--- a/drivers/devfreq/tegra-devfreq.c >+++ b/drivers/devfreq/tegra-devfreq.c >@@ -500,6 +500,8 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq, > clk_set_min_rate(tegra->emc_clock, rate); > clk_set_rate(tegra->emc_clock, 0); > >+ *freq = rate; >+ > return 0; > } > >-- >2.5.0 >