RE: [PATCH V3 00/14] drivers: hv: kvp

KY Srinivasan
2012-08-17T01:12:40Z

> -----Original Message-----
> From: K. Y. Srinivasan [mailto:kys@microsoft.com]
> Sent: Thursday, August 16, 2012 8:45 PM
> To: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org; olaf@aepfle.de;
> apw@canonical.com; ben@decadent.org.uk
> Cc: KY Srinivasan
> Subject: [PATCH V3 00/14] drivers: hv: kvp
>
> This patch set expands the KVP (Key Value Pair) functionality to
> implement the mechanism to GET/SET IP addresses in the guest. This
> functionality is used in Windows Server 2012 to implement VM
> replication functionality. The way IP configuration information
> is managed is distro specific. Based on the feedback I have gotten
> from Olaf, Greg, Steve, Ben and Mairus, I have chosen to seperate
> distro specific code from this patch-set. Most of the GET operation
> can be implemented in a way that is completely distro independent and
> I have implemented that as such and is included in this patch-set.
> Some of the attributes that can only be fetched in a distro
> dependent way as well the mechanism for configuring an interface
> (the SET operation) that is clearly distro specific is to be
> implemented via external scripts that will be invoked via the KVP
> code. We define here the interface to these scripts.
>
> Adding support for IP injection resulted in some changes to the
> protocol between the user level daemon and the kernel driver.
> These changes have been implemented in way that would retain
> compatibility with older daemons. I would like to thank Olaf and
> Greg for pointing out the compatibility issue.
>
> This version of the patch set addresses all of the comments that I
> have received to date from Olaf, Ben and others. Specifically, I have
> cleanedup all of the string manipulation code. Furthermore, I have also
> simplified the format of the interface configuration file that is
> generated by the KVP daemon and gotten rid of some constant strings that
> may not be relevant on all distros. I would like to thank Olaf and Ben
> for their detailed review.
>
> Following are the changes from V2 of this patch set:
>
> 1. Addressed the indentation issue Greg noted in the patch:
> 0001-Drivers-hv-kvp-Support-the-new-IP-injection-messages.patch
>
> 2. Cleaned up the Reviewed-byi line based on input from Ben and Greg.
>
> 3. Since Ben had an identical patch for properly closing the open
> streams, I have not included that patch in this series.
>
> 4. Greg applied the first 3 patches of the V2 patch set. This version
> has the remaining patches.

Greg,

Please drop this set. In my haste to send out the patches, I have sent out the wrong patches. I am going to send out the correct set in a minute.

Regards,

K. Y

>
>
> K. Y. Srinivasan (14):
> Drivers: hv: kvp: Support the new IP injection messages
> Tools: hv: Prepare to expand kvp_get_ip_address() functionality
> Tools: hv: Further refactor kvp_get_ip_address()
> Tools: hv: Gather address family information
> Tools: hv: Gather subnet information
> Tools: hv: Represent the ipv6 mask using CIDR notation
> Tools: hv: Gather ipv[4,6] gateway information
> Tools: hv: Gather DNS information
> Tools: hv: Gather DHCP information
> Tools: hv: Implement the KVP verb - KVP_OP_SET_IP_INFO
> Tools: hv: Rename the function kvp_get_ip_address()
> Tools: hv: Implement the KVP verb - KVP_OP_GET_IP_INFO
> Tools: hv: Get rid of some unused variables
> Tools: hv: Correctly type string variables
>
> drivers/hv/hv_kvp.c | 141 +++++++-
> include/linux/hyperv.h | 2 +
> tools/hv/hv_kvp_daemon.c | 866
> ++++++++++++++++++++++++++++++++++++++++++----
> 3 files changed, 942 insertions(+), 67 deletions(-)
>
> --
> 1.7.4.1
>
>
>