From: Emil Goode <emilgoode@gmail.com>
To: alan@linux.intel.com, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Emil Goode <emilgoode@gmail.com>
Subject: [PATCH 2/2] tty: serial: Remove explicit use of devm_kfree
Date: Sat, 18 Aug 2012 18:12:49 +0200 [thread overview]
Message-ID: <1345306369-10407-2-git-send-email-emilgoode@gmail.com> (raw)
In-Reply-To: <1345306369-10407-1-git-send-email-emilgoode@gmail.com>
There is no reason to explicitly call devm_kfree
in probe or remove functions.
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/tty/serial/max310x.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
index 06ff5ad..2bc28a5 100644
--- a/drivers/tty/serial/max310x.c
+++ b/drivers/tty/serial/max310x.c
@@ -1198,7 +1198,6 @@ err_freq:
err_out:
dev_set_drvdata(dev, NULL);
- devm_kfree(dev, s);
return ret;
}
@@ -1234,8 +1233,6 @@ static int __devexit max310x_remove(struct spi_device *spi)
if (s->pdata->exit)
s->pdata->exit();
- devm_kfree(dev, s);
-
return ret;
}
--
1.7.10.4
prev parent reply other threads:[~2012-08-18 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 16:12 [PATCH 1/2] tty: serial: Check return code of gpiochip_remove Emil Goode
2012-08-18 16:12 ` Emil Goode [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345306369-10407-2-git-send-email-emilgoode@gmail.com \
--to=emilgoode@gmail.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).