From: Joe Perches <joe@perches.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Jim Cromie <jim.cromie@gmail.com>,
Jason Baron <jbaron@redhat.com>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH] drivers-core: beware dev_printk() from printing nonsense
Date: Mon, 20 Aug 2012 11:13:13 -0700 [thread overview]
Message-ID: <1345486393.3252.3.camel@joe2Laptop> (raw)
In-Reply-To: <50326B84.4010204@linutronix.de>
On Mon, 2012-08-20 at 18:53 +0200, Sebastian Andrzej Siewior wrote:
> On 08/20/2012 05:26 PM, Greg Kroah-Hartman wrote:
> >> skip:
> >> - if (level[3])
> >> + if (level[sizeof(KERN_ERR) - 1])
> >
> > This has already been fixed in my driver-core tree and will go to Linus
> > in a few hours.
>
> Ah. So I'm too late. Care to send a patch which replace [2] with the
> sizeof() operator like above?
Nope, the better fix is to use a different mechanism.
See commit acc8fa41ad31c5
("printk: add generic functions to find KERN_<LEVEL> headers")
and
commit 04d2c8c83d0e3a
("printk: convert the format for KERN_<LEVEL> to a 2 byte pattern")
I'll submit that "better fix" shortly after Greg's update has
been pulled/merged by Linus.
cheers, Joe
prev parent reply other threads:[~2012-08-20 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 10:33 [PATCH] drivers-core: beware dev_printk() from printing nonsense Sebastian Andrzej Siewior
2012-08-20 15:26 ` Greg Kroah-Hartman
2012-08-20 16:53 ` Sebastian Andrzej Siewior
2012-08-20 18:13 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345486393.3252.3.camel@joe2Laptop \
--to=joe@perches.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox