From: David Howells <dhowells@redhat.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: dhowells@redhat.com, Zhihao Cheng <chengzhihao1@huawei.com>,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Yi Zhang <yi.zhang@huawei.com>
Subject: Re: [PATCH v2] afs: Fix memory leak in afs_put_sysnames()
Date: Mon, 01 Jun 2020 18:08:43 +0100 [thread overview]
Message-ID: <1346217.1591031323@warthog.procyon.org.uk> (raw)
In-Reply-To: <779b327f-b0fa-e21f-cbf6-5cadeca58581@web.de>
Markus Elfring <Markus.Elfring@web.de> wrote:
> > sysnames should be freed after refcnt being decreased to zero in
> > afs_put_sysnames().
>
> How do you think about a wording variant like the following?
>
> Release the sysnames object after its reference counter was decreased
> to zero.
I would say "reference count" not "reference counter" personally. I would
also say "afs_sysnames" rather than "sysnames". Perhaps something like:
Fix afs_put_sysnames() to actually free the specified afs_sysnames
object after its reference count has been decreased to zero and its
contents have been released.
> Will it matter to mention the size of the data structure "afs_sysnames"?
Why is it necessary to do so?
David
next prev parent reply other threads:[~2020-06-01 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 14:40 [PATCH v2] afs: Fix memory leak in afs_put_sysnames() Markus Elfring
2020-06-01 17:08 ` David Howells [this message]
2020-06-01 18:04 ` [v2] " Markus Elfring
2020-06-01 18:52 ` David Howells
2020-06-02 5:51 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-06-01 13:27 [PATCH v2] " Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346217.1591031323@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Markus.Elfring@web.de \
--cc=chengzhihao1@huawei.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox