[PATCH 5/7] Fix up a pointer-integer size mismatch warning in tps62360_probe()

[PATCH 5/7] Fix up a pointer-integer size mismatch warning in tps62360_probe()

[David Howells]

Fix up the following pointer-integer size mismatch warning in tps62360_probe():

	drivers/regulator/tps62360-regulator.c: In function 'tps62360_probe':
	drivers/regulator/tps62360-regulator.c:363:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
	   chip_id = (int)match->data;
		     ^

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Laxman Dewangan <ldewangan@nvidia.com>
cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

 drivers/regulator/tps62360-regulator.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/tps62360-regulator.c b/drivers/regulator/tps62360-regulator.c
index c2c0185a2dcd..c3fa15a299b1 100644
--- a/drivers/regulator/tps62360-regulator.c
+++ b/drivers/regulator/tps62360-regulator.c
@@ -360,7 +360,7 @@ static int tps62360_probe(struct i2c_client *client,
 			dev_err(&client->dev, "Error: No device match found\n");
 			return -ENODEV;
 		}
-		chip_id = (int)match->data;
+		chip_id = (int)(long)match->data;
 		if (!pdata)
 			pdata = of_get_tps62360_platform_data(&client->dev);
 	} else if (id) {

Re: [PATCH 5/7] Fix up a pointer-integer size mismatch warning in tps62360_probe()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

On Fri, Jan 03, 2014 at 04:07:55PM +0000, David Howells wrote:
> Fix up the following pointer-integer size mismatch warning in tps62360_probe():
> 
> 	drivers/regulator/tps62360-regulator.c: In function 'tps62360_probe':

Applied, but please follow the patch submission process in
SubmittingPatches - you need to CC things to maintainers and use subject
lines appropriate to the subsystem.  Things that don't go to people's
inboxes are likely to be missed, as are things that don't look relevant
from a scan of the subject line.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 5/7] Fix up a pointer-integer size mismatch warning in tps62360_probe()

[David Howells]

Mark Brown <broonie@kernel.org> wrote:

> you need to CC things to maintainers

	warthog>grep -i tps6 MAINTAINERS 
	warthog1>

I cc'd Laxman who is the only person mentioned in the file.

I cc'd you who is mentioned in the "regulator" section and who appears in
sign-offs in the log.

There is no "regulator" list in the MAINTAINERS file.

David

Re: [PATCH 5/7] Fix up a pointer-integer size mismatch warning in tps62360_probe()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

On Mon, Jan 06, 2014 at 04:40:28PM +0000, David Howells wrote:
> Mark Brown <broonie@kernel.org> wrote:

> > you need to CC things to maintainers

> 	warthog>grep -i tps6 MAINTAINERS 
> 	warthog1>

> I cc'd Laxman who is the only person mentioned in the file.

> I cc'd you who is mentioned in the "regulator" section and who appears in
> sign-offs in the log.

But you didn't CC Liam who comaintains the subsystem and for me you used
a random address from signoffs on old commits (which you will doubtless
have noticed bounces) rather than the address in MAINTAINERS.  It looks
awfully like you only used signoffs here...

> There is no "regulator" list in the MAINTAINERS file.

Right, lkml is fine there - IIRC that was prompted by another patch I
noticed in the series, or it could just have been part of the
boilerplate response for these things.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]