From: Davidlohr Bueso <dave@gnu.org>
To: Jens Axboe <axboe@kernel.dk>, Matt Domsch <Matt_Domsch@dell.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] partitions: efi: verify header is outside usable area
Date: Wed, 05 Sep 2012 11:18:27 +0200 [thread overview]
Message-ID: <1346836707.2559.5.camel@offbook> (raw)
The first usable logical block can be used by a GUID partition
entry, and therefore cannot be used by the header.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
block/partitions/efi.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/block/partitions/efi.c b/block/partitions/efi.c
index 7795bb4..abf33a2 100644
--- a/block/partitions/efi.c
+++ b/block/partitions/efi.c
@@ -363,6 +363,13 @@ static int is_gpt_valid(struct parsed_partitions *state, u64 lba,
goto fail;
}
+ /* The header must be outside usable range */
+ if (le64_to_cpu((*gpt)->first_usable_lba) < lba &&
+ le64_to_cpu((*gpt)->last_usable_lba) > lba) {
+ pr_debug("GPT: Header is inside usable area\n");
+ goto fail;
+ }
+
/* Check that sizeof_partition_entry has the correct value */
if (le32_to_cpu((*gpt)->sizeof_partition_entry) != sizeof(gpt_entry)) {
pr_debug("GUID Partitition Entry Size check failed.\n");
--
1.7.4.1
reply other threads:[~2012-09-05 9:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346836707.2559.5.camel@offbook \
--to=dave@gnu.org \
--cc=Matt_Domsch@dell.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox