From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759583Ab2ILOtX (ORCPT ); Wed, 12 Sep 2012 10:49:23 -0400 Received: from casper.infradead.org ([85.118.1.10]:53868 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755891Ab2ILOtW convert rfc822-to-8bit (ORCPT ); Wed, 12 Sep 2012 10:49:22 -0400 Message-ID: <1347461351.15764.47.camel@twins> Subject: Re: [PATCH v2 1/3] hrtimer: add hrtimer_init_cpu() From: Peter Zijlstra To: Stephane Eranian Cc: LKML , "mingo@elte.hu" , "ak@linux.intel.com" , "Yan, Zheng" , Robert Richter , Thomas Gleixner , Eric Dumazet Date: Wed, 12 Sep 2012 16:49:11 +0200 In-Reply-To: References: <1347459195-5491-1-git-send-email-eranian@google.com> <1347459195-5491-2-git-send-email-eranian@google.com> <1347459984.15764.34.camel@twins> <1347460719.15764.42.camel@twins> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-09-12 at 16:46 +0200, Stephane Eranian wrote: > I am fine with dropping this patch. I just found it odd there was a per-cpu > data reference embedded deep into the call. I wanted things to be more > explicit. I know it works without the proposed change. Ah the reason its there is to make sure the base pointer is a valid base pointer, this avoids an extra conditional in a number of places. Note that it uses raw_get_cpu_var(), so it doesn't even actually know which specific pointer goes in.