From: Peter Zijlstra <peterz@infradead.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Alex Shi <alex.shi@intel.com>,
mingo@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org,
Venkatesh Pallipadi <venki@google.com>
Subject: Re: [PATCH 1/2] nohz: clean up select_nohz_load_balancer()
Date: Thu, 13 Sep 2012 10:25:25 +0200 [thread overview]
Message-ID: <1347524725.15764.102.camel@twins> (raw)
In-Reply-To: <1347388424.26695.133.camel@sbsiddha-desk.sc.intel.com>
On Tue, 2012-09-11 at 11:33 -0700, Suresh Siddha wrote:
> > nohz_balance_enter_idle is good a name too. but I name it as
> > set_nohz_tick_stopped, since there is a clear_nohz_tick_stopped(), that
> > just do the opposed action of this function. According to this, is it
> > better to another function to nohz_balance_leave_idle()?
> > Or keep their current name?
> >
>
> Yes that will be more appropriate name.
I've made it:
nohz_balance_{enter,exit}_idle()
Most of the nohz stuff has the {enter,exit}.
next prev parent reply other threads:[~2012-09-13 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 7:10 [PATCH 1/2] nohz: clean up select_nohz_load_balancer() Alex Shi
2012-09-10 7:10 ` [PATCH 2/2] sched: trigger_load_balance clean up Alex Shi
2012-09-11 18:36 ` Suresh Siddha
2012-09-12 7:58 ` Alex Shi
2012-09-12 22:16 ` Suresh Siddha
2012-09-10 15:26 ` [PATCH 1/2] nohz: clean up select_nohz_load_balancer() Peter Zijlstra
2012-09-11 1:27 ` Alex Shi
2012-09-11 18:33 ` Suresh Siddha
2012-09-13 8:25 ` Peter Zijlstra [this message]
2012-09-14 6:15 ` [tip:sched/core] sched/nohz: Clean " tip-bot for Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347524725.15764.102.camel@twins \
--to=peterz@infradead.org \
--cc=alex.shi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).