Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver

Mark Brown
2012-09-13T12:04:04Z

On Thu, Sep 13, 2012 at 05:38:36PM +0530, Ashish Chavan wrote:
> On Wed, 2012-09-12 at 10:57 +0800, Mark Brown wrote:

> > > + aif_ctrl |= (DA9055_AIF_OE | DA9055_AIF_EN);

> > DAPM.

> Here the trouble in making it DAPM based is that there is no separate
> control for AIF input and output. It is confirmed that AIF_EN is the
> master control bit, which enables both output as well as input. The AIF
> _OE bit is redundant. If we use the same control bit(i.e AIF_EN) for
> both DAPM_AIF_IN and DAPM_AIF_OUT, there will be obvious side effects.
> Is there any other way to take care of this? Or should we leave it
> outside DAPM?

Use a supply widget.