From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH 1/4] perf header: Add struct perf_header_info
Date: Thu, 20 Sep 2012 22:53:16 +0900 [thread overview]
Message-ID: <1348149196.1510.2.camel@leonhard> (raw)
In-Reply-To: <20120920114307.GB11325@ghostprotocols.net>
2012-09-20 (목), 04:43 -0700, Arnaldo Carvalho de Melo:
> Em Thu, Sep 20, 2012 at 02:36:44PM +0900, Namhyung Kim escreveu:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> >
> > The struct perf_header_info will preserve environment information at
> > the time of perf record. It can be accessed anytime after parsing a
> > perf.data file if needed.
>
> > +struct perf_header_info {
>
> I think it would be better named as 'perf_session_env' i.e. the
> environment (machine (name), hardware(nr_cpus, total_mem, etc) and
> OS(release, version) details) where a 'perf' 'session' took place.
>
> perf 'header info' look more like 'what is the version in the header?
> what about its endianity, and other 'header' details :-)
Okay, will rename and resend tomorrow!
/me always failed to make a good name :(
Thanks,
Namhyung
next prev parent reply other threads:[~2012-09-20 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 5:36 [PATCH 0/4] perf header: Save and reuse feature information in header (v3) Namhyung Kim
2012-09-20 5:36 ` [PATCH 1/4] perf header: Add struct perf_header_info Namhyung Kim
2012-09-20 11:43 ` Arnaldo Carvalho de Melo
2012-09-20 13:53 ` Namhyung Kim [this message]
2012-09-20 5:36 ` [PATCH 2/4] perf header: Add ->process callbacks to most of features Namhyung Kim
2012-09-20 5:36 ` [PATCH 3/4] perf header: Use pre-processed header info when printing Namhyung Kim
2012-09-20 5:36 ` [PATCH 4/4] perf header: Remove unused @feat arg from ->process callback Namhyung Kim
2012-09-20 13:44 ` [PATCH 0/4] perf header: Save and reuse feature information in header (v3) David Ahern
2012-09-20 13:55 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348149196.1510.2.camel@leonhard \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox