From: Li Zhong <zhong@linux.vnet.ibm.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()
Date: Mon, 24 Sep 2012 13:30:26 +0800 [thread overview]
Message-ID: <1348464626.2475.13.camel@ThinkPad-T420> (raw)
Just noticed that after commit 919f797, it is possible that
scsi_cmd_to_driver() returns NULL. This patch adds the NULL checking for drv
returned from the above function.
Maybe it is not possible at run time, but from the code itself, we'd better
have this check?
This patch actually is a delta of my previous patch
[https://lkml.org/lkml/2012/4/11/814] and commit 919f797
Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
---
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 2936b44..b9dd7f0 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -832,7 +832,7 @@ void scsi_finish_command(struct scsi_cmnd *cmd)
if (cmd->request->cmd_type != REQ_TYPE_BLOCK_PC) {
int old_good_bytes = good_bytes;
drv = scsi_cmd_to_driver(cmd);
- if (drv->done)
+ if (drv && drv->done)
good_bytes = drv->done(cmd);
/*
* USB may not give sense identifying bad sector and
next reply other threads:[~2012-09-24 5:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 5:30 Li Zhong [this message]
2012-09-24 5:44 ` [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver() James Bottomley
2012-09-24 7:03 ` Li Zhong
2012-09-24 7:35 ` James Bottomley
2012-09-24 9:25 ` Li Zhong
2012-09-24 9:33 ` James Bottomley
2012-09-27 2:02 ` Martin K. Petersen
2012-09-27 4:44 ` James Bottomley
2012-09-27 9:51 ` [PATCH scsi] Short the path length of scsi_cmd_to_driver() Li Zhong
2012-09-27 17:43 ` Martin K. Petersen
2012-09-28 7:13 ` Li Zhong
2012-09-28 7:45 ` James Bottomley
2012-09-27 17:41 ` [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver() Martin K. Petersen
2012-09-28 7:48 ` James Bottomley
2012-09-29 4:23 ` [PATCH v2 scsi] Short the path length of scsi_cmd_to_driver() Li Zhong
2012-10-02 22:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348464626.2475.13.camel@ThinkPad-T420 \
--to=zhong@linux.vnet.ibm.com \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox