From: Peter Senna Tschudin <peter.senna@gmail.com>
To: mchehab@infradead.org
Cc: g.liakhovetski@gmx.de, laurent.pinchart@ideasonboard.com,
fabio.estevam@freescale.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Peter Senna Tschudin <peter.senna@gmail.com>
Subject: [PATCH V2 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code
Date: Mon, 24 Sep 2012 11:11:03 +0200 [thread overview]
Message-ID: <1348477863-6728-1-git-send-email-peter.senna@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1209232313500.31250@axis700.grange>
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/media/platform/soc_camera/mx2_camera.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c
index 256187f..01d7c11 100644
--- a/drivers/media/platform/soc_camera/mx2_camera.c
+++ b/drivers/media/platform/soc_camera/mx2_camera.c
@@ -1800,12 +1800,14 @@ static int __devinit mx2_camera_probe(struct platform_device *pdev)
if (!res_emma || !irq_emma) {
dev_err(&pdev->dev, "no EMMA resources\n");
+ err = -ENODEV;
goto exit_free_irq;
}
pcdev->res_emma = res_emma;
pcdev->irq_emma = irq_emma;
- if (mx27_camera_emma_init(pcdev))
+ err = mx27_camera_emma_init(pcdev);
+ if (err)
goto exit_free_irq;
}
--
1.7.11.4
prev parent reply other threads:[~2012-09-24 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 15:23 [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code Peter Senna Tschudin
2012-09-23 19:34 ` Fwd: " Mauro Carvalho Chehab
2012-09-23 21:15 ` Guennadi Liakhovetski
2012-09-24 9:11 ` Peter Senna Tschudin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348477863-6728-1-git-send-email-peter.senna@gmail.com \
--to=peter.senna@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=g.liakhovetski@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox