From: Peter Hurley <peter@hurleysoftware.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: "linux1394-devel@lists.sourceforge.net"
<linux1394-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firewire: remove global lock around address handlers, convert to RCU
Date: Fri, 28 Sep 2012 13:03:45 -0400 [thread overview]
Message-ID: <1348851825.2229.1.camel@thor> (raw)
In-Reply-To: <20120928113837.4f5de6ef@stein>
On Fri, 2012-09-28 at 05:38 -0400, Stefan Richter wrote:
> On Sep 27 Stefan Richter wrote:
> > --- a/drivers/firewire/core-transaction.c
> > +++ b/drivers/firewire/core-transaction.c
> > @@ -489,7 +489,7 @@ static struct fw_address_handler *lookup
> > {
> > struct fw_address_handler *handler;
> >
> > - list_for_each_entry(handler, list, link) {
> > + list_for_each_entry_rcu(handler, list, link) {
> > if (handler->offset < offset + length &&
> > offset < handler->offset + handler->length)
> > return handler;
> [...]
>
> I will add an #include <linux/rculist.h> to core-transaction.c.
Thanks Stefan. Apologies for missing that.
Peter Hurley
next prev parent reply other threads:[~2012-09-28 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1345359002.6089.3.camel@thor>
[not found] ` <20120819122759.30f9981f@stein>
[not found] ` <1345403610.7706.72.camel@thor>
[not found] ` <20120820030450.7f5bfa37@stein>
2012-09-27 19:44 ` [PATCH] firewire: remove global lock around address handlers, convert to RCU Stefan Richter
2012-09-27 19:46 ` [PATCH] firewire: addendum to address handler RCU conversion Stefan Richter
2012-09-28 9:38 ` [PATCH] firewire: remove global lock around address handlers, convert to RCU Stefan Richter
2012-09-28 17:03 ` Peter Hurley [this message]
2012-09-28 17:05 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348851825.2229.1.camel@thor \
--to=peter@hurleysoftware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox