From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] perf x86_64: Fix rsp register for system call fast path
Date: Tue, 02 Oct 2012 12:44:04 +0200 [thread overview]
Message-ID: <1349174644.7780.23.camel@twins> (raw)
In-Reply-To: <1349112712-2590-1-git-send-email-jolsa@redhat.com>
On Mon, 2012-10-01 at 19:31 +0200, Jiri Olsa wrote:
> @@ -696,7 +696,7 @@ struct perf_branch_stack {
>
> struct perf_regs_user {
> __u64 abi;
> - struct pt_regs *regs;
> + struct pt_regs regs;
> };
That's somewhat unfortunate but unavoidable I guess, can't go modify pt_regs.
> + if (uregs->abi)
> + stack_size = perf_sample_ustack_size(sample_stack_user,
> + header->size,
> +
just a style nit, please add {} for all multi-line single stmt
constructs like that, even though not strictly required.
It reduces the possible confusion between multi-line and multi-statement
and reads easier.
next prev parent reply other threads:[~2012-10-02 10:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 17:31 [PATCH] perf x86_64: Fix rsp register for system call fast path Jiri Olsa
2012-10-02 10:44 ` Peter Zijlstra [this message]
2012-10-02 14:58 ` [PATCHv2] " Jiri Olsa
2012-10-02 15:49 ` Frederic Weisbecker
2012-10-02 16:06 ` Jiri Olsa
2012-10-02 16:16 ` Frederic Weisbecker
2012-10-03 12:29 ` [PATCHv3] " Jiri Olsa
2012-10-03 12:35 ` Frederic Weisbecker
2012-10-03 13:13 ` [PATCHv4] " Jiri Olsa
2012-10-03 13:22 ` Peter Zijlstra
2012-10-03 13:30 ` Jiri Olsa
2012-10-04 10:38 ` [PATH 0/2] perf: x86_64 rsp related changes Jiri Olsa
2012-10-04 10:38 ` [PATCH 1/2] perf x86_64: Fix rsp register for system call fast path Jiri Olsa
2012-10-04 10:38 ` [PATCH 2/2] perf: Simplify the sample's user regs/stack retrieval Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349174644.7780.23.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox