From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: YAMANE Toshiaki <yamanetoshi@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Fix trailing whitespace in trace.h
Date: Tue, 02 Oct 2012 15:12:03 +0300 [thread overview]
Message-ID: <1349179923.13371.186.camel@smile> (raw)
In-Reply-To: <1349178827-29643-1-git-send-email-yamanetoshi@gmail.com>
On Tue, 2012-10-02 at 20:53 +0900, YAMANE Toshiaki wrote:
> fixed below checkpatch error.
>
> -ERROR: trailing whitespace
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
> ---
> drivers/staging/rts_pstor/trace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h
> index cf60a1b..740999c 100644
> --- a/drivers/staging/rts_pstor/trace.h
> +++ b/drivers/staging/rts_pstor/trace.h
> @@ -39,7 +39,7 @@ static inline char *filename(char *path)
> while (*ptr != '\0') {
> if ((*ptr == '\\') || (*ptr == '/'))
> path = ptr + 1;
> -
> +
> ptr++;
> }
For me it seems total filename() function could be squeezed to just strrchr(path, '/') + 1;
Moreover there is already basename() in the lib/dynamic_debug.c you
could rename, export and reuse.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2012-10-02 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 11:53 [PATCH 1/3] Fix trailing whitespace in trace.h YAMANE Toshiaki
2012-10-02 11:54 ` [PATCH 2/3] Add parenthesis to macros with complex values " YAMANE Toshiaki
2012-10-02 12:13 ` Andy Shevchenko
2012-10-02 12:21 ` Dan Carpenter
2012-10-03 0:19 ` Toshiaki Yamane
2012-10-02 11:54 ` [PATCH 3/3] Fix line over 80 character issue and space before tabs issue " YAMANE Toshiaki
2012-10-02 12:23 ` Dan Carpenter
2012-10-03 0:19 ` Toshiaki Yamane
2012-10-02 12:12 ` Andy Shevchenko [this message]
2012-10-03 0:18 ` [PATCH 1/3] Fix trailing whitespace " Toshiaki Yamane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349179923.13371.186.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox