From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 2/3] regmap: Make return code checks consistent
Date: Thu, 4 Oct 2012 18:36:15 +0100 [thread overview]
Message-ID: <1349372177-18931-2-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1349372177-18931-1-git-send-email-broonie@opensource.wolfsonmicro.com>
The range code was written to check for return codes less than zero as
errors but throughout the rest of the API return codes not equal to zero
are errors. Change all these checks to match the house style.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/base/regmap/regmap.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 4bb926c..baf9586 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -606,7 +606,7 @@ struct regmap *regmap_init(struct device *dev,
}
ret = regcache_init(map, config);
- if (ret < 0)
+ if (ret != 0)
goto err_range;
regmap_debugfs_init(map, config->name);
@@ -803,7 +803,7 @@ static int _regmap_select_page(struct regmap *map, unsigned int *reg,
map->work_buf = orig_work_buf;
- if (ret < 0)
+ if (ret != 0)
return ret;
}
@@ -854,7 +854,7 @@ static int _regmap_raw_write(struct regmap *map, unsigned int reg,
if (range) {
ret = _regmap_select_page(map, ®, range,
val_len / map->format.val_bytes);
- if (ret < 0)
+ if (ret != 0)
return ret;
}
@@ -930,7 +930,7 @@ int _regmap_write(struct regmap *map, unsigned int reg,
range = _regmap_range_lookup(map, reg);
if (range) {
ret = _regmap_select_page(map, ®, range, 1);
- if (ret < 0)
+ if (ret != 0)
return ret;
}
@@ -1096,7 +1096,7 @@ static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
if (range) {
ret = _regmap_select_page(map, ®, range,
val_len / map->format.val_bytes);
- if (ret < 0)
+ if (ret != 0)
return ret;
}
--
1.7.10.4
next prev parent reply other threads:[~2012-10-04 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 17:36 [PATCH 1/3] regmap: Factor range lookup out of page selection Mark Brown
2012-10-04 17:36 ` Mark Brown [this message]
2012-10-04 17:36 ` [PATCH 3/3] regmap: Split raw writes that cross window boundaries Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349372177-18931-2-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).